PHP :: Bug #64340 :: sockets tests failed

Bug #64340

sockets tests failed

Submitted:

2013-03-02 18:05 UTC

Modified:

2013-10-02 14:32 UTC

Votes:	1
Avg. Score:	3.0 ± 0.0
Reproduced:	0 of 0 (0.0%)

From:

reeze@php.net

Assigned:

laruence (profile)

Status:

Closed

Package:

Sockets related

PHP Version:

5.5.0alpha5

OS:

Mac OSX 10.8

Private report:

CVE-ID:

None

View Developer Edit

[2013-03-02 18:05 UTC] reeze@php.net

Patches

ipv6-pktinfo-and-tiny-test-fix (last revision 2013-03-02 18:05 UTC by reeze@php.net)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2013-03-02 18:05 UTC] reeze@php.net

The following patch has been added/updated:

Patch Name: ipv6-pktinfo-and-tiny-test-fix
Revision:   1362247530
URL:        https://bugs.php.net/patch-display.php?bug=64340&patch=ipv6-pktinfo-and-tiny-test-fix&revision=1362247530

[2013-03-02 18:08 UTC] reeze@php.net

-Assigned To: +Assigned To: cataphract

[2013-03-02 19:19 UTC] cataphract@php.net

What's the deal with having changed the header includes order? I don't really like having headers that must be included in a specific order, that usually means one header depends on another, but fails to include it; if there's something that requires the headers to be in a specific order that should be fixed instead.

As to rest (the skip and the define for __APPLE_USE_RFC_3542), I see no problem with it; you can commit it yourself.

[2013-03-03 02:53 UTC] laruence@php.net

Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=f2246f352fc01295c370728d68a9bcd2bb546652
Log: Fixed Bug #64340  (sockets tests failed) Patch by Reeze

[2013-03-03 02:53 UTC] laruence@php.net

-Status: Assigned +Status: Closed

[2013-03-03 02:53 UTC] laruence@php.net

Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=f2246f352fc01295c370728d68a9bcd2bb546652
Log: Fixed Bug #64340  (sockets tests failed) Patch by Reeze

[2013-03-03 02:55 UTC] laruence@php.net

Thank you for your bug report. This issue has already been fixed
in the latest released version of PHP, which you can download at 
http://www.php.net/downloads.php

I commmitted, since reeze doesn't has PHP karma.

please verify the fix.

[2013-03-03 02:55 UTC] laruence@php.net

-Status: Closed +Status: Assigned -Assigned To: cataphract +Assigned To: laruence

[2013-03-03 02:57 UTC] laruence@php.net

-Status: Assigned +Status: Feedback

[2013-03-04 18:21 UTC] reeze@php.net

Hi, cataphract
   The macro __APPLE_USE_RFC_3542 must be defined before including netinet/in.h,
but not all of the our c files include php_sockets.h in the topmost, but by indirectly
include other header files.

eg: 
$ head -n 1 conversions.c
sockaddr_conv.h

$ header -n 5 sockaddr_conv.h
...
#include <php_network.h>
#include "php_sockets.h" /* php_socket */

php_network.h wil be included <netinet/in.h> before the macro defined. and php_network.h has to been included
before php_sockets.h, so I have to  move conversion.h up instead.

in the mean time, in convesion.h  <netinet/in.h> was included before php_sockets.h too, so I have to move it 
up to meet the requirement of the macro. 



The current partial patch breaks the build because of missing the left part:

Undefined symbols for architecture x86_64:
  "_from_zval_write_in6_pktinfo", referenced from:
      _init_ancillary_registry in sendrecvmsg.o
      _php_do_setsockopt_ipv6_rfc3542 in sendrecvmsg.o
  "_to_zval_read_in6_pktinfo", referenced from:
      _init_ancillary_registry in sendrecvmsg.o
      _php_do_getsockopt_ipv6_rfc3542 in sendrecvmsg.o
ld: symbol(s) not found for architecture x86_64

[2013-03-05 05:58 UTC] laruence@php.net

Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=3f67d5ae434236be1db2ee54baf85725ac7b6a56
Log: Revert &quot;Fixed Bug #64340  (sockets tests failed) Patch by Reeze&quot;

[2013-03-05 05:58 UTC] laruence@php.net

-Status: Feedback +Status: Closed

[2013-03-05 06:04 UTC] laruence@php.net

Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=3f67d5ae434236be1db2ee54baf85725ac7b6a56
Log: Revert &quot;Fixed Bug #64340  (sockets tests failed) Patch by Reeze&quot;

[2013-03-05 06:05 UTC] laruence@php.net

I revert the previous fix, since the build broken.

I am wondering, if don't fix that, what's the problem is?

thanks

[2013-03-05 10:47 UTC] reeze@php.net

Hi, 
the attached patch is intend to fix IPV6_PKTINFO failure, the commit didn't 
contain all of the fix. but only the macro define.

The patch isn't break build. but the partially applied patch. 
only define __APPLE_USE_RFCxxxx is not enough. the rest of the changes 
should be applied too.

I couldn't figure out a better solution which didn't require header 
inclusion order, since the macro itself required to be defined first.

[2013-03-05 10:47 UTC] reeze@php.net

-Status: Closed +Status: Re-Opened

[2013-03-05 11:34 UTC] laruence@php.net

there is one workaround:

#ifdef  __APPLE__
#define IPV6_PKTINFO        IPV6_2292PKTINFO
#define IPV6_HOPLIMIT       IPV6_2292HOPLIMIT
#define IPV6_NEXTHOP        IPV6_2292NEXTHOP
#define IPV6_HOPOPTS        IPV6_2292HOPOPTS
#define IPV6_DSTOPTS        IPV6_2292DSTOPTS
#define IPV6_RTHDR          IPV6_2292RTHDR
#define IPV6_PKTOPTIONS     IPV6_2292PKTOPTIONS
#endif 

will keep finding more better solution

[2013-10-02 14:32 UTC] mike@php.net

Any update on this?

[2013-11-17 09:31 UTC] laruence@php.net

Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=3f67d5ae434236be1db2ee54baf85725ac7b6a56
Log: Revert &quot;Fixed Bug #64340  (sockets tests failed) Patch by Reeze&quot;

[2013-11-17 09:31 UTC] laruence@php.net

-Status: Re-Opened +Status: Closed

[2013-11-17 09:31 UTC] laruence@php.net

Automatic comment on behalf of laruence
Revision: http://git.php.net/?p=php-src.git;a=commit;h=f2246f352fc01295c370728d68a9bcd2bb546652
Log: Fixed Bug #64340  (sockets tests failed) Patch by Reeze

	php.net \| support \| documentation \| report a bug \| advanced search \| search howto \| statistics \| random bug \| login
go to bug id or search bugs for


Copyright © 2001-2024 The PHP Group All rights reserved.	Last updated: Sat Dec 21 15:01:29 2024 UTC