php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #63362 Not needed but installed headers.
Submitted: 2012-10-25 13:43 UTC Modified: 2019-03-13 12:35 UTC
Votes:2
Avg. Score:3.0 ± 0.0
Reproduced:1 of 2 (50.0%)
Same Version:0 (0.0%)
Same OS:1 (100.0%)
From: remi@php.net Assigned:
Status: Wont fix Package: *General Issues
PHP Version: 5.4.8 OS: GNU/Linux (Fedora 18)
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2012-10-25 13:43 UTC] remi@php.net
Description:
------------
Various Windows specific headers are provided in the php sources
(of course, this is absolutely not a problem).

It will be great to not install them on other OS.

Installed headers list:

 TSRM/tsrm_win32.h
 TSRM/tsrm_config.w32.h
 Zend/zend_config.w32.h
 ext/mysqlnd/config-win.h
 ext/standard/winver.h
 main/win32_internal_function_disabled.h
 main/win95nt.h




Patches

Add a Patch

Pull Requests

Pull requests:

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-08-06 01:22 UTC] kalle@php.net
-Type: Bug +Type: Feature/Change Request
 [2016-08-06 01:22 UTC] kalle@php.net
Hi Remi

Now I'm no expert on the Unix build system, but it seems like a rather simple task and it does make a lot of sense to do that. On Windows we don't install non Windows platform specific headers with phpize either.
 [2019-03-12 00:41 UTC] petk@php.net
The following pull request has been associated:

Patch Name: Fix #63362: Not needed but installed headers
On GitHub:  https://github.com/php/php-src/pull/3937
Patch:      https://github.com/php/php-src/pull/3937.patch
 [2019-03-13 12:35 UTC] petk@php.net
-Status: Open +Status: Wont fix
 [2019-03-13 12:35 UTC] petk@php.net
According to the discussion on GitHub [1], the list of Windows specific headers is in the current version (PHP 7.2+) reduced to 5 files. Also total size of these files are about 24KB which is very small, even for very light Linux distributions such as Alpine and others. These additional files really shouldn't cause any issues with the *nix environments out there, yet for possible future other build options that might need these files it is a good step to leave them installable and not omit them or remove them.

If there's any other solution here, let m, @krakjoe, or @kalle know about it. Closing this.

[1] https://github.com/php/php-src/pull/3937
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Mar 28 18:01:29 2024 UTC