php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #63255 404 page looks amateur
Submitted: 2012-10-10 15:00 UTC Modified: 2013-10-24 07:55 UTC
From: pascal dot chevrel at free dot fr Assigned: yohgaki (profile)
Status: Closed Package: Built-in web server
PHP Version: master-Git-2012-10-10 (Git) OS: all
Private report: No CVE-ID: None
 [2012-10-10 15:00 UTC] pascal dot chevrel at free dot fr
Description:
------------
This is a followup to https://bugs.php.net/bug.php?id=63242 where I provided a patch to have html5 syntax and simpler html/css to the 404 page

The 404 page uses styles that were copy/pasted from a 2002 commit for phpinfo styling. It looks amateurish, title and text are not aligned, the blue background sticks to the title text and it depends partly on the browser default html rules, which means that there are differences in display across browsers for that page.

I propose a slight change of the css used that will result in something a bit leaner while keeping the same blue colour that represents PHP, here is a before/after screenshot:
http://chevrel.org/images/phpbugs/bug63242v2_compare.png

This is a simple patch that passes all tests, I will attach it here later today.


Patches

bug63255 (last revision 2012-10-10 16:10 UTC by pascal dot chevrel at free dot fr)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2012-11-09 12:36 UTC] pascal dot chevrel at free dot fr
Can somebody have a look at this simple patch? I saw that 5.4.9RC1 is released and I believe it contains my html fix for the 404 page (https://bugs.php.net/bug.php?id=63242), it would have been nice to have the css part included as well.
 [2013-10-24 07:55 UTC] yohgaki@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: yohgaki
 [2013-10-24 07:55 UTC] yohgaki@php.net
It seems fixed already.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Apr 25 09:01:29 2024 UTC