php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #63085 Systemd integration and daemonize
Submitted: 2012-09-14 05:40 UTC Modified: 2012-09-19 15:35 UTC
From: remi@php.net Assigned: fat
Status: Closed Package: FPM related
PHP Version: 5.4.7 OS: GNU/Linux (Fedora 17)
Private report: No CVE-ID:
 [2012-09-14 05:40 UTC] remi@php.net
Description:
------------
Currently "daemonize" is a option taken from configuration file.

I think is is quite ugly to have a starting script of systemd unit file to rely on a external configuration file.

I think a command line option will be more robust.

For ex, 
- in init script we could launch php-fpm --daemonize
- in systemd unit, we could launch php-fpm --nodaemonize

Without command line option, I propose to keep reading option from the config file (to not break existing configuration).

We could also imagine another option (--debug) which run in foreground and log everything need thing to screen (for interactive run).

What do you think ?
I could propose a patch


Patches

php-fpm-systemd.patch (last revision 2012-09-19 15:00 UTC) by remi@php.net)
php-fpm.service (last revision 2012-09-14 05:41 UTC) by remi@php.net)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2012-09-14 05:41 UTC] remi@php.net
The following patch has been added/updated:

Patch Name: php-fpm.service
Revision:   1347601268
URL:        https://bugs.php.net/patch-display.php?bug=63085&patch=php-fpm.service&revision=1347601268
 [2012-09-14 05:43 UTC] remi@php.net
I have join the systemd unit file used in Fedora.

Note : "type=Forking" is not present, 
so this rely on daemonize=no in config file.

It could be great to have this unit file (made more generic if needed) provided in php distribution.
 [2012-09-19 15:00 UTC] remi@php.net
The following patch has been added/updated:

Patch Name: php-fpm-systemd.patch
Revision:   1348066817
URL:        https://bugs.php.net/patch-display.php?bug=63085&patch=php-fpm-systemd.patch&revision=1348066817
 [2012-09-19 15:03 UTC] remi@php.net
In the proposed php-fpm-systemd.patch:
- add --daemonize option, and update init.d to use it
- add --nodaemonize option
- update --help output
- update man page for new options and systemd use
- add systemd unit file, which use --nodaemonize
 [2012-09-19 15:35 UTC] tony2001@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: fat
 [2012-09-27 22:55 UTC] fat@php.net
Automatic comment on behalf of fat
Revision: http://git.php.net/?p=php-src.git;a=commit;h=851a04bb7b680954249e825ea3fef420f7d66bb7
Log: - Fixed bug #63085 (Systemd integration and daemonize)
 [2012-09-27 22:55 UTC] fat@php.net
-Status: Assigned +Status: Closed
 [2012-09-27 23:19 UTC] fat@php.net
Automatic comment on behalf of fat
Revision: http://git.php.net/?p=php-src.git;a=commit;h=64a0e7cdc2a90a13dd238068a7ff3d357de284b4
Log: - Fixed bug #63085 (Systemd integration and daemonize)
 [2012-09-28 07:05 UTC] laruence@php.net
Automatic comment on behalf of fat
Revision: http://git.php.net/?p=php-src.git;a=commit;h=64a0e7cdc2a90a13dd238068a7ff3d357de284b4
Log: - Fixed bug #63085 (Systemd integration and daemonize)
 
PHP Copyright © 2001-2014 The PHP Group
All rights reserved.
Last updated: Fri Apr 18 02:02:27 2014 UTC