|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2012-09-03 03:24 UTC] pvasilevich at parallels dot com
Description: ------------ Wincache 1.3.4 and PHP 5.4.6 There is reliability problem caused by incorrect handling of memory allocation errors. Test script: --------------- Unfortunately, there are no test script to reproduce this problem. This problem appears suddenly, only if memory cannot be allocated in specified code areas. I can provide 2 crash dumps for both problems if necessary. Please review and apply provided patch. After applying this patch I haven't found any reliability issues anymore. Expected result: ---------------- No Access Violation errors Actual result: -------------- Crash of PHP process Patcheswincache-1.3.4-500-error-updated.patch (last revision 2012-10-09 02:59 UTC by pvasilevich at parallels dot com)wincache-1.3.4-500-error (last revision 2012-09-03 03:24 UTC by pvasilevich at parallels dot com) Pull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Wed Nov 05 18:00:01 2025 UTC |
Hello ericsten, as I see you have commited 2 of 3 changes proposed in patch. There is still problem that could bring access violation crash: --- wincache_opcopy.c (revision 328119) +++ wincache_opcopy.c (working copy) @@ -3316,6 +3316,12 @@ if(ozendcl->parent != NULL) { clvalue[index].pcname = OSTRDUP(popcopy, ozendcl->parent->name); + if (clvalue[index].pcname == NULL) + { + result = popcopy->oomcode; + goto Finished; + } + zend_str_tolower(clvalue[index].pcname, strlen(clvalue[index].pcname)); } else It will be nice if you add this patch as well.