php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #61448 tests fail with icu >= 4.8
Submitted: 2012-03-20 08:54 UTC Modified: 2012-03-28 13:42 UTC
From: ab@php.net Assigned: ab (profile)
Status: Closed Package: intl (PECL)
PHP Version: 5.3.10 OS: windows
Private report: No CVE-ID: None
 [2012-03-20 08:54 UTC] ab@php.net
Description:
------------
The following tests fail with ICU >= 4.8 and partly with ICU >= 4.6

ext/intl/tests/locale_get_display_variant.phpt
ext/intl/tests/dateformat_parse_timestamp_parsepos.phpt
ext/intl/tests/formatter_format_currency.phpt
ext/intl/tests/locale_get_display_region.phpt
ext/intl/tests/dateformat_set_timezone_id.phpt
ext/intl/tests/dateformat_clone.phpt
ext/intl/tests/locale_get_display_script.phpt
ext/intl/tests/locale_parse_locale.phpt
ext/intl/tests/formatter_format.phpt
ext/intl/tests/dateformat_parse.phpt
ext/intl/tests/locale_get_display_name.phpt
ext/intl/tests/dateformat_parse_localtime_parsepos.phpt
ext/intl/tests/dateformat_localtime.phpt
ext/intl/tests/msgfmt_fail.phpt
ext/intl/tests/collator_get_locale.phpt
ext/intl/tests/dateformat_get_set_pattern.phpt
ext/intl/tests/formatter_get_set_attribute.phpt
ext/intl/tests/formatter_get_set_symbol.phpt
ext/intl/tests/collator_create.phpt
ext/intl/tests/locale_filter_matches.phpt
ext/intl/tests/locale_get_keywords.phpt

In the diffs supplied the following was done:

* failed test are skipped on icu <= 4.2
* failed tests was duplicated for icu >= 4.8
* new tests was adopted according to the new icu data
* in the new tests metazones (PST, etc.) was replaced with GMT-* to avoid locale 
issues (see http://publib.boulder.ibm.com/infocenter/radhelp/v8/index.jsp?
topic=/com.ibm.wsadapters.rad.jca_peoplesoft.doc/doc/cpeo_nonenglish_in.html)

To test the windows build, the latest ICU 4.8 must be used, get it here:
http://site.icu-project.org/download/48

Test script:
---------------
intl test suite

Expected result:
----------------
tests pass

Actual result:
--------------
tests fail

Patches

intl_icu_4.8_fix.1.diff (last revision 2012-03-20 09:08 UTC by ab@php.net)
intl_icu_4.8_fix.0.diff (last revision 2012-03-20 09:08 UTC by ab@php.net)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2012-03-20 09:08 UTC] ab@php.net
The following patch has been added/updated:

Patch Name: intl_icu_4.8_fix.0.diff
Revision:   1332234486
URL:        https://bugs.php.net/patch-display.php?bug=61448&patch=intl_icu_4.8_fix.0.diff&revision=1332234486
 [2012-03-20 09:08 UTC] ab@php.net
The following patch has been added/updated:

Patch Name: intl_icu_4.8_fix.1.diff
Revision:   1332234509
URL:        https://bugs.php.net/patch-display.php?bug=61448&patch=intl_icu_4.8_fix.1.diff&revision=1332234509
 [2012-03-20 09:23 UTC] ab@php.net
-Assigned To: +Assigned To: mattficken
 [2012-03-28 13:40 UTC] ab@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=bd928f05921a9c3595181c9b04e8024ad9ab9303
Log: Fix bug #61448 intl tests fail with icu &gt;= 4.8
 [2012-03-28 13:40 UTC] ab@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=103995ba22ed13e5924acdad91a8dc444d72cde1
Log: Fix bug #61448 intl tests fail with icu &gt;= 4.8
 [2012-03-28 13:42 UTC] ab@php.net
-Status: Assigned +Status: Closed -Assigned To: mattficken +Assigned To: ab
 [2012-03-28 13:42 UTC] ab@php.net
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.


 [2012-03-28 15:34 UTC] ab@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=bd928f05921a9c3595181c9b04e8024ad9ab9303
Log: Fix bug #61448 intl tests fail with icu &gt;= 4.8
 [2012-03-29 04:23 UTC] ab@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=bd928f05921a9c3595181c9b04e8024ad9ab9303
Log: Fix bug #61448 intl tests fail with icu &gt;= 4.8
 [2012-03-29 04:23 UTC] ab@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src.git;a=commit;h=103995ba22ed13e5924acdad91a8dc444d72cde1
Log: Fix bug #61448 intl tests fail with icu &gt;= 4.8
 [2012-04-02 22:57 UTC] mattficken@php.net
These patches pass on PHP5.3.11rc1 on Windows 7 sp1x64.

It does not break for me on Linux x64 (Gentoo and Fedora 16) with PHP5.3.11rc1.
 [2014-10-07 23:28 UTC] stas@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=bd928f05921a9c3595181c9b04e8024ad9ab9303
Log: Fix bug #61448 intl tests fail with icu &gt;= 4.8
 [2014-10-07 23:28 UTC] stas@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=103995ba22ed13e5924acdad91a8dc444d72cde1
Log: Fix bug #61448 intl tests fail with icu &gt;= 4.8
 [2014-10-07 23:38 UTC] stas@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=bd928f05921a9c3595181c9b04e8024ad9ab9303
Log: Fix bug #61448 intl tests fail with icu &gt;= 4.8
 [2014-10-07 23:38 UTC] stas@php.net
Automatic comment on behalf of ab
Revision: http://git.php.net/?p=php-src-security.git;a=commit;h=103995ba22ed13e5924acdad91a8dc444d72cde1
Log: Fix bug #61448 intl tests fail with icu &gt;= 4.8
 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Wed Oct 21 16:01:24 2020 UTC