php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #59346 Unable to build pecl/spread with spread 3.x
Submitted: 2010-08-08 09:06 UTC Modified: 2010-08-09 12:41 UTC
From: admin at saltwaterc dot net Assigned:
Status: Closed Package: spread (PECL)
PHP Version: 5.3.2 OS: Linux
Private report: No CVE-ID: None
 [2010-08-08 09:06 UTC] admin at saltwaterc dot net
Description:
------------
There's a misplaced variable declaration of a type that 
doesn't exist till spread 4.x. Since the latest Ubuntu Server 
still includes spread 3.x, the issue came up right away. The 
patch is included below.

Reproduce code:
---------------
Index: php_spread.c
===================================================================
--- php_spread.c	(revision 301984)
+++ php_spread.c	(working copy)
@@ -866,7 +866,6 @@
 
 		if (Is_reg_memb_mess(stype)) {
 			/* join/leave/disconnect/network */
-			membership_info memb_info;
 			char *changed_member;
 
 			add_assoc_long(return_value, "group_size", ngrps);
@@ -885,6 +884,7 @@
 
 			/* getting additional info */
 #if (SPREAD_VERSION >> 24) >= 4
+			membership_info memb_info;
 			SP_get_memb_info(mess, stype, &memb_info);
 			changed_member = memb_info.changed_member;
 #else

Expected result:
----------------
[...]

Build complete.
Don't forget to run 'make test'.


Actual result:
--------------
~/spread/php_spread.c: In function zif_spread_receive:
~/spread/php_spread.c:869: error: membership_info undeclared 
(first use in this function)
~/spread/php_spread.c:869: error: (Each undeclared identifier 
is reported only once
~/spread/php_spread.c:869: error: for each function it appears 
in.)
~/spread/php_spread.c:869: error: expected ; before memb_info


Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-08-09 12:41 UTC] rrichards@php.net
This bug has been fixed in SVN.

In case this was a documentation problem, the fix will show up at the
end of next Sunday (CET) on pecl.php.net.

In case this was a pecl.php.net website problem, the change will show
up on the website in short time.
 
Thank you for the report, and for helping us make PECL better.


 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Dec 13 14:01:28 2024 UTC