|
|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2009-01-06 18:50 UTC] gotnew at yahoo dot com
Description:
------------
the memcache object will lose its port information the second time it access data or get status from Memcache server. This works with the previous 2.2.4 version.
And it also seems to work with Ubuntu 8.10.
Reproduce code:
---------------
<?php
$mc = new MemcachePool;
$mc->addServer("10.10.1.159", "11211");
$ss = $mc->getExtendedStats();
print_r($ss);
for ($i = 0; $i < 100; $i ++)
{
sleep(1);
$ss = $mc->getExtendedStats();
print_r($ss);
}
?>
Expected result:
----------------
it should print out the server ip:port and the stats array.
Actual result:
--------------
the second time it prints the stats, the server's port number become 0. Notice the first time, it shows port number 11211, but from second time on, it shows 0.
Array
(
[10.10.1.159:11211] => Array
(
...omitted..
)
)
Array
(
[10.10.1.159:0] => Array
(
...omitted...
)
)
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||
Copyright © 2001-2024 The PHP GroupAll rights reserved. |
Last updated: Mon Apr 29 16:01:31 2024 UTC |
The problem is a memory stomp in memcache_pool.c. The offending line is: if (!io->stream || php_stream_cast(io->stream, PHP_STREAM_AS_FD_FOR_SELECT, (void **)&(io->fd), 1) != SUCCESS) { Which looks fine, until you realize that on platforms where sizeof(void**) == 8 and sizeof(int) (the declared type on io->fd which is of struct type mmc_stream_t) == 4. The relevant part of the struct is: struct mmc_stream { php_stream *stream; int fd; unsigned short port; /* rest of struct elided */ } So the very next struct element gets overwritten. Here is the GDB trace showing the memory stomp in action: (gdb) print *mmc $18 = {tcp = {stream = 0xddee60, fd = 0, port = 11211, chunk_size = 32768, status = 0, failed = 0, retry_interval = 15, buffer = {value = {c = 0x0, len = 0, a = 0}, idx = 0}, read = 0, readline = 0, input = {value = '\0' <repeats 4095 times>, idx = 0}}, udp = { stream = 0x0, fd = 0, port = 0, chunk_size = 32768, status = 0, failed = 0, retry_interval = 15, buffer = {value = {c = 0x0, len = 0, a = 0}, idx = 0}, read = 0, readline = 0, input = {value = '\0' <repeats 4095 times>, idx = 0}}, sendreq = 0x0, readreq = 0x0, buildreq = 0x0, sendqueue = {items = 0x0, alloc = 0, head = 0, tail = 0, len = 0}, readqueue = {items = 0x0, alloc = 0, head = 0, tail = 0, len = 0}, host = 0xddc820 "10.10.1.159", timeout = 1, persistent = 1, reqid = 0, error = 0x0, errnum = 0} (gdb) n 695 php_stream_set_option(io->stream, PHP_STREAM_OPTION_BLOCKING, 0, NULL); (gdb) print *mmc $19 = {tcp = {stream = 0xddee60, fd = 5, port = 0, chunk_size = 32768, status = 0, failed = 0, retry_interval = 15, buffer = {value = {c = 0x0, len = 0, a = 0}, idx = 0}, read = 0, readline = 0, input = {value = '\0' <repeats 4095 times>, idx = 0}}, udp = { stream = 0x0, fd = 0, port = 0, chunk_size = 32768, status = 0, failed = 0, retry_interval = 15, buffer = {value = {c = 0x0, len = 0, a = 0}, idx = 0}, read = 0, readline = 0, input = {value = '\0' <repeats 4095 times>, idx = 0}}, sendreq = 0x0, readreq = 0x0, buildreq = 0x0, sendqueue = {items = 0x0, alloc = 0, head = 0, tail = 0, len = 0}, readqueue = {items = 0x0, alloc = 0, head = 0, tail = 0, len = 0}, host = 0xddc820 "10.10.1.159", timeout = 1, persistent = 1, reqid = 0, error = 0x0, errnum = 0} As you can see immediately after that line, port now = 0. A patch that fixes this looks like: =================================================================== RCS file: /repository/pecl/memcache/Attic/memcache_pool.c,v retrieving revision 1.1.2.32 diff -u -r1.1.2.32 memcache_pool.c --- memcache_pool.c 8 Jan 2009 21:56:17 -0000 1.1.2.32 +++ memcache_pool.c 13 Jan 2009 02:13:56 -0000 @@ -677,8 +677,9 @@ efree(hash_key); } + void *fd; /* check connection and extract socket for select() purposes */ - if (!io->stream || php_stream_cast(io->stream, PHP_STREAM_AS_FD_FOR_SELECT, (void **)&(io->fd), 1) != SUCCESS) { + if (!io->stream || php_stream_cast(io->stream, PHP_STREAM_AS_FD_FOR_SELECT, &fd, 1) != SUCCESS) { mmc_server_seterror(mmc, errstr != NULL ? errstr : "Connection failed", errnum); mmc_server_deactivate(pool, mmc TSRMLS_CC); @@ -688,7 +689,7 @@ return MMC_REQUEST_FAILURE; } - + io->fd = (int)fd; io->status = MMC_STATUS_CONNECTED; php_stream_auto_cleanup(io->stream); This fix should also work on 32 bit compiles... But I didn't test it. The patch fixes the problems we're seeing. I hope this can be included post-haste. To be clear: this bug will only affect 64 bit compiles.