|
|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
[2012-07-29 16:51 UTC] felipe@php.net
-Status: Open
+Status: Assigned
-Assigned To:
+Assigned To: francois
[2012-07-29 18:46 UTC] francois@php.net
[2012-07-29 18:46 UTC] francois@php.net
-Status: Assigned
+Status: Closed
-Block user comment: No
+Block user comment: Yes
|
|||||||||||||||||||||||||||
Copyright © 2001-2024 The PHP GroupAll rights reserved. |
Last updated: Sat Dec 21 12:01:31 2024 UTC |
Description: ------------ The build fails with -Werror=format-security Reproduce code: --------------- /home/oden/RPM/BUILD/automap-1.1.0/Automap.c:1411: error: format not a string literal and no format arguments /home/oden/RPM/BUILD/automap-1.1.0/Automap.c:1413: error: format not a string literal and no format arguments Expected result: ---------------- It should build, and also preferably without all those compiler warnings. Actual result: -------------- Proposed fix: --- Automap.c 2008-01-19 04:07:09.000000000 +0100 +++ Automap.c.oden 2009-01-04 12:24:31.000000000 +0100 @@ -1408,9 +1408,9 @@ cellpadding=3 cellspacing=0 style=\"bord ,1,&zp TSRMLS_CC); if (ZVAL_IS_STRING(&zret)) { php_printf("<a href=\"%s\">%s</a>",Z_STRVAL(zret),fname); - } else php_printf(fname); + } else php_printf("%s", fname); zval_dtor(&zret); - } else php_printf(fname); + } else php_printf("%s", fname); php_printf("</td></tr>\n");