php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #58200 [PATCH] Windows compile fails
Submitted: 2008-05-23 13:59 UTC Modified: 2008-05-23 17:24 UTC
From: edwardzyang at thewritingpot dot com Assigned:
Status: Closed Package: APC (PECL)
PHP Version: 5_2 CVS-2008-05-23 (dev) OS: Windows Vista
Private report: No CVE-ID: None
 [2008-05-23 13:59 UTC] edwardzyang at thewritingpot dot com
Description:
------------
Windows compile for APC fails due to C2229 on snaps.php.net (the usual Microsoft stupidity, apparently). Linked patch fixes issue; hopefully moving around the defs doesn't interfere with APC:

http://www.thewritingpot.com/patches/apc-c2229.patch

BTW, how come 3.0.19 isn't tagged in the CVS?

Cheers,
Edward


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2008-05-23 17:17 UTC] gopalv82 at yahoo dot com
It's tagged now, but it's perhaps not compiler stupidity.

I had a char data[0]; at the end of apc_pool (apc_pool.h), which is causing the error. Ironically, it was left there as a warning for people to realize apc_pool is larger than it seems.

Removing that char data[0]; will fix your compile error.

Committing in a few mins to CVS HEAD (which is not 3.0.19)
 [2008-05-23 17:24 UTC] gopalv82 at yahoo dot com
http://news.php.net/php.pecl.cvs/10796

should fix it, please re-open if it doesn't
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Mar 29 12:01:27 2024 UTC