php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #56648 Build with PHP's PCRE headers
Submitted: 2005-11-14 18:40 UTC Modified: 2005-11-16 18:28 UTC
From: ramsey@php.net Assigned: sniper (profile)
Status: Closed Package: filter (PECL)
PHP Version: Irrelevant OS: -
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2005-11-14 18:40 UTC] ramsey@php.net 
Description:
------------
As per the FIXME on line 23 of logical_filters.c, fix the filter extension to use PHP's built-in PCRE headers instead of the system PCRE headers.

(I have a patch for this that I will submit.)

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2005-11-14 19:14 UTC] ramsey@php.net 
Index: logical_filters.c
===================================================================
RCS file: /repository/pecl/filter/logical_filters.c,v
retrieving revision 1.8
diff -u -u -r1.8 logical_filters.c
--- logical_filters.c	28 Sep 2005 09:14:43 -0000	1.8
+++ logical_filters.c	14 Nov 2005 23:16:41 -0000
@@ -19,9 +19,10 @@
 #include "php_filter.h"
 #include "filter_private.h"
 #include "ext/standard/url.h"
+#include "main/php_compat.h"
 
-/* FIXME: should build against PHP's pcre's headers */
-#include "pcre.h"
+struct real_pcre;
+typedef struct real_pcre pcre;
 
 #define FETCH_LONG_OPTION(var_name, option_name)                                                                         \
 	var_name = 0;                                                                                                        \
 [2005-11-16 11:02 UTC] sniper@php.net 
I have partially fixed this already, need to finalize the config.m4 changes needed. (the patch above is not the way to fix this)
 [2005-11-16 18:28 UTC] sniper@php.net 
Several issues had to be fixed. The least of them not being the fact that the headers under ext/pcre have not been installed, ever. They will be as of PHP 5.1.0.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Wed Apr 24 03:01:29 2024 UTC