php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #56534 Inactive maintainers not fully implemented
Submitted: 2005-09-08 13:05 UTC Modified: 2005-09-08 18:32 UTC
From: thesaur@php.net Assigned: pajoye (profile)
Status: Closed Package: PECL website (PECL)
PHP Version: Irrelevant OS: NA
Private report: No CVE-ID: None
 [2005-09-08 13:05 UTC] thesaur@php.net
Description:
------------
Just to keep a sticky here...

Lukas mentioned on IRC that inactive maintainers are not properly listed as such on their user profiles. Also, they can see, but not use, the "edit maintainers" tabs on the package (this should be OK). And they can edit the package using the "edit" tab (no ok).


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2005-09-08 13:07 UTC] smith at pooteeweet dot org
Actually I was wrong .. they can edit .. though i am not sure if they should be able to ..
 [2005-09-08 15:02 UTC] klaus at capitalfocus dot org
Here's a patch for account-info. I think it should work.

Index: account-info.php
===================================================================
RCS file: /repository/pearweb/public_html/account-info.php,v
retrieving revision 1.41
diff -u -r1.41 account-info.php
--- account-info.php    28 Jul 2005 16:25:33 -0000      1.41
+++ account-info.php    8 Sep 2005 19:01:29 -0000
@@ -160,7 +160,7 @@

 <?php

-$query = 'SELECT p.id, p.name, m.role'
+$query = 'SELECT p.id, p.name, m.role, m.active'
        . ' FROM packages p, maintains m'
        . ' WHERE m.handle = ? AND p.id = m.package'
        . ' ORDER BY p.name';
@@ -171,6 +171,11 @@
     echo '<li>';
     print_link('/package/' . htmlspecialchars($row['name']),
                htmlspecialchars($row['name']));
+    echo sprintf("(%s%s)<br />",
+                    ($row['active'] == 0 ? "inactive " : ""),
+                    htmlspecialchars($row['role'])
+                );
+
     echo ' &nbsp;(' . htmlspecialchars($row['role']) . ')';
     echo ' &nbsp;<small><a href="/bugs/search.php?package_name%5B%5D=';
     echo htmlspecialchars($row['name']) . '&amp;cmd=display">Bugs</a></small>';
 [2005-09-08 18:32 UTC] pierre dot php at gmail dot com
This bug has been fixed in CVS.

If this was a documentation problem, the fix will appear on pear.php.net by the end of next Sunday (CET).

If this was a problem with the pear.php.net website, the change should be live shortly.

Otherwise, the fix will appear in the package's next release.

Thank you for the report and for helping us make PEAR better.

I think they should be able to edit.

One can set himself as inactive and come back later.

However the accout info page reflects now the maintainer status.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Fri Apr 19 03:01:27 2024 UTC