php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #56309 Missing quotation marks in php_pdo_firebird_int.h
Submitted: 2005-02-19 18:17 UTC Modified: 2005-02-26 19:37 UTC
From: adamg at pld-linux dot org Assigned: wez (profile)
Status: Closed Package: PDO_FIREBIRD (PECL)
PHP Version: Irrelevant OS: 64 bit Linux
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2005-02-19 18:17 UTC] adamg at pld-linux dot org 
Description:
------------
In php_pdo_firebird_int.h there is a block of #ifdefs that defines LL_MASK and LL_LIT constants. However, in the first part it lacks quotation marks around value, causing compile to fail (shows up on 64 bit systems). It does not affect 32 bit systems though. 

Reproduce code:
---------------
Add quotation marks in '#define LL_MASK l'
--- php_pdo_firebird_int.h      23 Jun 2004 13:26:08 -0000      1.8
+++ php_pdo_firebird_int.h      19 Feb 2005 23:13:06 -0000
@@ -34,7 +34,7 @@
 #define SHORT_MAX (1 << (8*sizeof(short)-1))
 
 #if SIZEOF_LONG == 8
-# define LL_MASK l
+# define LL_MASK "l"
 # define LL_LIT(lit) lit ## L
 #else
 # ifdef PHP_WIN32

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2005-02-26 19:37 UTC] wez@php.net 
This bug has been fixed in CVS.

In case this was a documentation problem, the fix will show up at the
end of next Sunday (CET) on pecl.php.net.

In case this was a pecl.php.net website problem, the change will show
up on the website in short time.
 
Thank you for the report, and for helping us make PECL better.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Apr 20 03:01:28 2024 UTC