php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #56178 Parameters of some functions should be passed by reference
Submitted: 2004-08-23 04:19 UTC Modified: 2017-04-01 19:51 UTC
From: vrana@php.net Assigned:
Status: Wont fix Package: dbplus (PECL)
PHP Version: 5CVS-2004-08-23 (dev) OS: Irrelevant
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2004-08-23 04:19 UTC] vrana@php.net
Description:
------------
I believe that parameters of some functions should be forced to be passed by reference. Here is a patch for it:

RCS file: /repository/pecl/dbplus/dbplus.c,v
retrieving revision 1.2
diff -u -r1.2 dbplus.c
--- dbplus.c	30 Mar 2004 18:10:06 -0000	1.2
+++ dbplus.c	23 Aug 2004 08:09:07 -0000
@@ -67,22 +67,22 @@
     PHP_FE(dbplus_aql,  NULL)
     PHP_FE(dbplus_chdir,    NULL)
     PHP_FE(dbplus_close,    NULL)
-    PHP_FE(dbplus_curr, NULL)
+    PHP_FE(dbplus_curr, second_arg_force_ref)
     PHP_FE(dbplus_errno,    NULL)
     PHP_FE(dbplus_errcode,  NULL)
     PHP_FE(dbplus_find,     NULL)
-    PHP_FE(dbplus_first,    NULL)
+    PHP_FE(dbplus_first,    second_arg_force_ref)
     PHP_FE(dbplus_flush,    NULL)
     PHP_FE(dbplus_freealllocks, NULL)
     PHP_FE(dbplus_freelock, NULL)
     PHP_FE(dbplus_freerlocks,   NULL)
     PHP_FE(dbplus_getlock,  NULL)
     PHP_FE(dbplus_getunique,    NULL)
-    PHP_FE(dbplus_info, NULL)
-    PHP_FE(dbplus_last, NULL)
-    PHP_FE(dbplus_next, NULL)
+    PHP_FE(dbplus_info, third_arg_force_ref)
+    PHP_FE(dbplus_last, second_arg_force_ref)
+    PHP_FE(dbplus_next, second_arg_force_ref)
     PHP_FE(dbplus_open, NULL)
-    PHP_FE(dbplus_prev, NULL)
+    PHP_FE(dbplus_prev, second_arg_force_ref)
     PHP_FE(dbplus_rchperm,  NULL)
     PHP_FE(dbplus_rcreate,  NULL)
     PHP_FE(dbplus_rcrtexact,    NULL)
@@ -101,7 +101,7 @@
     PHP_FE(dbplus_setindexbynumber, NULL)
     PHP_FE(dbplus_sql,  NULL)
     PHP_FE(dbplus_tcl,  NULL)
-    PHP_FE(dbplus_tremove,  NULL)
+    PHP_FE(dbplus_tremove,  third_arg_force_ref)
     PHP_FE(dbplus_undo, NULL)
     PHP_FE(dbplus_undoprepare,  NULL)
     PHP_FE(dbplus_unlockrel,    NULL)



Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2017-04-01 19:51 UTC] tpunt@php.net
-Status: Open +Status: Wont fix
 [2017-04-01 19:51 UTC] tpunt@php.net
Due to this extension not seeing any activity since 2003, this issue will not be fixed. We are therefore closing this now.
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Thu Nov 21 12:01:22 2019 UTC