php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #56047 PATCH fix styles for manual navigation
Submitted: 2004-04-30 11:13 UTC Modified: 2004-05-02 18:45 UTC
From: danielc at analysisandsolutions dot com Assigned: mj (profile)
Status: Closed Package: PECL website (PECL)
PHP Version: Irrelevant OS: Irrelevant
Private report: No CVE-ID: None
 [2004-04-30 11:13 UTC] danielc at analysisandsolutions dot com
Description:
------------
The navigation bar for the manual needs better formatting to reduce the number of times it becomes so wide that it forces the body text off the right hand side of the page.

Also, there needs to be an easy way to add style sheets to the <header>.  I've added the $extra_styles array for this purpose.

Here's the patch
http://www.analysisandsolutions.com/pear/manual.nav.style.diff


Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2004-04-30 12:51 UTC] mj@php.net
Absolute font sizes are definitively no nice thing.  Can you get rid of them and use relative sizes instead?
 [2004-04-30 13:17 UTC] danielc at analysisandsolutions dot com
In general I agree with you about absolute font sizes.  The reason they're acceptable in this situation is the text in question is just the navigation stuff (previous/next and language links, etc) which isn't really meant to be read.

Also, the fixed size comes in handy here because the existing style sheets already set the body font to a relative size.  If that size gets changed at some future time, it would impact how the navigation lays out.  This already happened once recently.

If you disagree, please change "8pt" to "75%" in style-manual.css and then apply it.

Thanks.
 [2004-04-30 23:47 UTC] helgi at trance dot is
Well one should never use pt on web since those are mostly only ment for printing ;)
 [2004-05-01 16:09 UTC] danielc at analysisandsolutions dot com
Helgi, please provide a citation regarding "pt" in CSS being meant for printed matter.  It's not mentioned in the CSS 1 recommendation, that's for sure.

When fixed size fonts are needed (as I believe they are in this case), pt is the way to go because they are more consistently rendered than px.

Martin, even though I'm arguing for pt, it's not THAT big a deal.  Just apply the patch with the existing 8pt or substituting 75% and I'll be happy.

Thanks.
 [2004-05-01 16:55 UTC] mj@php.net
Commited.

I changed the absolute font sizes to relative ones and additionally I also "cleaned up" the stylesheet a bit.
 [2004-05-01 20:00 UTC] helgi at trance dot is
(next) (previous) is way to small ... I'm using FireFox on Linux with 1024 res. ;/
But I don't wanna touch the style.css ... Martin will probly never the less reverte that ;D  So Martin make it a little bigger :)
 [2004-05-01 21:16 UTC] danielc at analysisandsolutions dot com
Just making sure.  You just mean the words "(previous)" and "(next)," and not the whole thing, right?  If so, remove the <small> around them.  No need to revert the whole patch.

They look fine to me.  Guess it depends on the base font size in your browser's preferences.  See why I wanted to use pt?  Perhaps try pt and see how it looks?

By the way, my resolution is 1024, browser is a recent Mozilla build, os is Windows, base font size is 20 px.
 [2004-05-02 01:47 UTC] helgi at trance dot is
res. 1024, Firefox 0.8, Linux, basefont 16px;

But well didn't mean he should revert the whole patch ;) Thought this was all defined in CSS since I saw many small tags stripped out ... But I see now there is infact a small tag :)
Well Martin will remove that if the see's a need :)
 [2004-05-02 04:31 UTC] mj@php.net
I removed the <small> tag.

Helgi: If this still turns out to be a problem for you, please come up with a patch.  (I wouldn't mind using absolute font sizes if that _really_ fixes the problem.)
 [2004-05-02 18:45 UTC] helgi at trance dot is
Martin it looks great now :) So no need for a patch ;)
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Dec 26 10:01:29 2024 UTC