php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #55893 Edit Maintainers broken
Submitted: 2003-10-15 10:13 UTC Modified: 2005-05-31 10:16 UTC
From: thesaur@php.net Assigned: mj (profile)
Status: Closed Package: PECL website (PECL)
PHP Version: Irrelevant OS: Irrelevant
Private report: No CVE-ID: None
View Add Comment Developer Edit
Anyone can comment on a bug. Have a simpler test case? Does it work for you on a different platform? Let us know!
Just going to say 'Me too!'? Don't clutter the database with that please !
Your email address:
MUST BE VALID
Solve the problem:
8 - 2 = ?
Subscribe to this entry?

 
 [2003-10-15 10:13 UTC] thesaur@php.net
Description:
------------
When I try to add a maintainer to my package (HTML_CSS), the following happens:

1) I select the user ('farell')
2) I select the type of access ('developer')
3) I click "Add as"

Then a page comes up with the following message:

Done
Back

When I click on the "Back" link, it returns me to the panel, which remains unchanged.

Of course, I can add a maintainer by simply uploading a release, but I'm not ready for a release just yet.


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2003-10-15 10:32 UTC] mj@php.net
Works for me. Can please someone, who has no administrator rights (this might distort my results), please try that as well?
 [2003-10-21 14:53 UTC] heino@php.net
I get the exact same result, nothing happens...
 [2003-10-22 06:26 UTC] mj@php.net
This seems to be a problem with the Javascript support in Internet Explorer. I'll have a look at it later. Please use Mozilla if you need to urgently update maintainers.
 [2004-08-13 11:59 UTC] mj@php.net
Does this problem still persist?
 [2004-08-13 13:30 UTC] klaus at capitalfocus dot org
Yes. Removing someone works. Adding someone does not. (Tested with IE 6.0, XP SP2RC2)
 [2005-03-10 11:22 UTC] techtonik@php.net
JS in package-maintainers.js is a little bit confusing.
Can I suggest rename form from "form" to "editmaintainers" and also add name attribute for search form in site header?

Another issue can be (unlikely, but still) in shortened prototype for JS Option object.

+++ package-maintainers.js	2005-03-10 
- item = new Option(name + " (" + handle + ", " + role + ")", value);
+ item = new Option(name + " (" + handle + ", " + role + ")", value, false, true);

In either case - can you supply string from your address bar when the page with "Done" link is displayed?
 [2005-03-13 08:55 UTC] techtonik@php.net
Here are two patches, which can solve the problem
Patch for pearweb\public_html\admin\package-maintainers.php

--- package-maintainers_old.php	2005-02-19 02:34:52.000000000 +0200
+++ package-maintainers.php	2005-03-13 15:14:06.000000000 +0200
@@ -110,13 +110,13 @@
     echo '  </td>';
 
     echo '  <td>';
-    echo '  <input type="submit" onClick="addMaintainer(); return false" name="add" value="Add as" />';
+    echo '  <input type="button" onClick="addMaintainer();" name="add" value="Add as" />';
     echo '  <select name="role" size="1">';
     echo '    <option value="lead">lead</option>';
     echo '    <option value="developer">developer</option>';
     echo '    <option value="helper">helper</option>';
     echo '  </select><br /><br />';
-    echo '  <input type="submit" onClick="removeMaintainer(); return false" name="remove" value="Remove" />';
+    echo '  <input type="button" onClick="removeMaintainer();" name="remove" value="Remove" />';
     echo '  </td>';
 
     echo '  <td>';
 [2005-03-31 06:50 UTC] techtonik@php.net
Here is the second part.
For pearweb\public_html\javascript\package-maintainers.js

--- package-maintainers_old.js	2005-02-19 02:34:58.000000000 +0200
+++ package-maintainers.js	2005-03-13 15:36:00.000000000 +0200
@@ -36,7 +36,7 @@
             role = getRole();
             handle = document.form.accounts.options[i].value;
             value = handle + "||" + role;
-            item = new Option(name + " (" + handle + ", " + role + ")", value);
+            item = new Option(name + " (" + handle + ", " + role + ")", value, false, true);
             document.form['maintainers[]'].options[document.form['maintainers[]'].length] = item;
         }
     }
@@ -61,6 +61,7 @@
     for (i = 0; i < document.form['maintainers[]'].length; i++) {
         field = document.form['maintainers[]'].options[i].selected = true;
     }
+    return true;
 }
 
 function activateAdd() {
 [2005-05-25 03:48 UTC] techtonik@php.net
Martin, have you received the patches I mailed you?
 [2005-05-25 06:00 UTC] pierre at dotgeek dot org
Please provide a link to the patch.

Doing so will help for other people to test your patch and/or apply if everything works fine.

Thanks for it btw :)

--Pierre
 [2005-05-30 03:50 UTC] techtonik@php.net
Here you are.

public_html/javascript/package-maintainers.js
http://www.megaupload.com/?d=045XQJH3

public_html/admin/package-maintainers.php
http://www.megaupload.com/?d=04Z0SSHM
 [2005-05-31 10:16 UTC] mj@php.net
This bug has been fixed in CVS.

In case this was a documentation problem, the fix will show up at the
end of next Sunday (CET) on pear.php.net.

In case this was a pear.php.net website problem, the change will show
up on the website in short time.
 
Thank you for the report, and for helping us make PEAR better.


 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Fri Nov 27 06:01:23 2020 UTC