|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2003-10-15 10:13 UTC] thesaur@php.net
Description:
------------
When I try to add a maintainer to my package (HTML_CSS), the following happens:
1) I select the user ('farell')
2) I select the type of access ('developer')
3) I click "Add as"
Then a page comes up with the following message:
Done
Back
When I click on the "Back" link, it returns me to the panel, which remains unchanged.
Of course, I can add a maintainer by simply uploading a release, but I'm not ready for a release just yet.
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Wed Dec 17 13:00:01 2025 UTC |
JS in package-maintainers.js is a little bit confusing. Can I suggest rename form from "form" to "editmaintainers" and also add name attribute for search form in site header? Another issue can be (unlikely, but still) in shortened prototype for JS Option object. +++ package-maintainers.js 2005-03-10 - item = new Option(name + " (" + handle + ", " + role + ")", value); + item = new Option(name + " (" + handle + ", " + role + ")", value, false, true); In either case - can you supply string from your address bar when the page with "Done" link is displayed?Here are two patches, which can solve the problem Patch for pearweb\public_html\admin\package-maintainers.php --- package-maintainers_old.php 2005-02-19 02:34:52.000000000 +0200 +++ package-maintainers.php 2005-03-13 15:14:06.000000000 +0200 @@ -110,13 +110,13 @@ echo ' </td>'; echo ' <td>'; - echo ' <input type="submit" onClick="addMaintainer(); return false" name="add" value="Add as" />'; + echo ' <input type="button" onClick="addMaintainer();" name="add" value="Add as" />'; echo ' <select name="role" size="1">'; echo ' <option value="lead">lead</option>'; echo ' <option value="developer">developer</option>'; echo ' <option value="helper">helper</option>'; echo ' </select><br /><br />'; - echo ' <input type="submit" onClick="removeMaintainer(); return false" name="remove" value="Remove" />'; + echo ' <input type="button" onClick="removeMaintainer();" name="remove" value="Remove" />'; echo ' </td>'; echo ' <td>';Here is the second part. For pearweb\public_html\javascript\package-maintainers.js --- package-maintainers_old.js 2005-02-19 02:34:58.000000000 +0200 +++ package-maintainers.js 2005-03-13 15:36:00.000000000 +0200 @@ -36,7 +36,7 @@ role = getRole(); handle = document.form.accounts.options[i].value; value = handle + "||" + role; - item = new Option(name + " (" + handle + ", " + role + ")", value); + item = new Option(name + " (" + handle + ", " + role + ")", value, false, true); document.form['maintainers[]'].options[document.form['maintainers[]'].length] = item; } } @@ -61,6 +61,7 @@ for (i = 0; i < document.form['maintainers[]'].length; i++) { field = document.form['maintainers[]'].options[i].selected = true; } + return true; } function activateAdd() {