php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #55888 Click on "View more info about package X" results in JavaScript error
Submitted: 2003-10-08 13:59 UTC Modified: 2003-12-17 04:55 UTC
From: sebastian at sebastian-r dot de Assigned: pajoye (profile)
Status: Closed Package: PECL website (PECL)
PHP Version: Irrelevant OS: Win XP Pro
Private report: No CVE-ID: None
View Developer Edit
 [2003-10-08 13:59 UTC] sebastian at sebastian-r dot de 
Description:
------------
Clicking on an info link of the package browser to "View more info about package X" results in a JavaScript error. 
I am using MS Internet Explorer 6 on Windows Xp Pro with all current updates and service packs installed.

Reproduce code:
---------------
Click on a "View more info about package X" image link at for example http://pear.php.net/packages.php?catpid=12&catname=Images using IE 6.

Expected result:
----------------
The package info should appear.

Actual result:
--------------
JavaScript error: PackageX is undefined

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2003-11-17 02:38 UTC] php at cipri dot com 
This patch should fix this bug.

-- 
Cipriano Groenendal



--- packages.html	Mon Nov 17 08:39:16 2003
+++ ok.packages.html	Mon Nov 17 08:37:58 2003
@@ -1,6 +1,6 @@
 <script language="JavaScript" type="text/javascript">

 <!--

-	function toggleMoreInfo(packageName, rowNode)

+	function toggleMoreInfo(packageName, packageID)

 	{

 		if (!document.getElementById) {

 			location.href = '/package/' + packageName;

@@ -120,7 +120,7 @@
 							<td valign="top"><?=$p['summary']?></td>

 							<td valign="top">

 								<?if($_browser->is_ie5up):?>

-									<a href="#" onclick="toggleMoreInfo(<?=$p['name']?>); return false" onmouseover="window.status = 'View more info about <?=$p['name']?>'; return true" onmouseout="window.status = ''" title="View more info about <?=$p['name']?>">

+									<a href="#" onclick="toggleMoreInfo(<?=$p['name']?>, <?=$p['id']?>); return false" onmouseover="window.status = 'View more info about <?=$p['name']?>'; return true" onmouseout="window.status = ''" title="View more info about <?=$p['name']?>">

 										<img src="gifs/moreinfo.gif" border="0" />

 									</a>

 								<?endif?>
 [2003-11-17 02:40 UTC] php at cipri dot com 
Okay, so there's no place to add an attachment....

Get the patch at http://www.cipri.com/pear/packages.diff.txt

-- 
Cipriano Groenendal
 [2003-12-17 04:55 UTC] pajoye@php.net 
This bug has been fixed in CVS.

In case this was a documentation problem, the fix will show up at the
end of next Sunday (CET) on pear.php.net.

In case this was a pear.php.net website problem, the change will show
up on the website in short time.
 
Thank you for the report, and for helping us make PEAR better.

Tested with IE5.5 and 6.0 latest SP.

hope it works with others, if not we rather have to drop JS toys instead.

thanks for the fix,

pierre
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Mon Dec 30 14:01:28 2024 UTC