php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #54208 PhD_PEAR: no attributes for table-related tags
Submitted: 2011-03-09 19:07 UTC Modified: 2012-04-06 14:55 UTC
From: avb@php.net Assigned:
Status: Closed Package: Doc Build problem
PHP Version: Irrelevant OS: Irrelevant
Private report: No CVE-ID:
 [2011-03-09 19:07 UTC] avb@php.net
Description:
------------
For some strange reason phpdotnet\phd\Package_PEAR_XHTML overrides methods for formatting table tags defined in phpdotnet\phd\Package_Generic_XHTML, for example:

    public function format_entry($open, $name, $attrs, $props)
    {
        if ($open) {
            if ($props['empty']) {
                return '<td></td>';
            }
            return '<td>';
        }
        return '</td>';
    }

Unlike code in parent class, this does not add any attributes whatsoever, so it is impossible to even do colspan and rowspan in PEAR manual.

Commenting out format_table(), format_entry() and format_th_entry() improves output a lot.

Test script:
---------------
<entry morerows="1">...</entry>

Expected result:
----------------
<td rowspan="2">...</td>

Actual result:
--------------
<td>...</td>

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2012-02-04 18:42 UTC] avb@php.net
Automatic comment from SVN on behalf of avb
Revision: http://svn.php.net/viewvc/?view=revision&amp;revision=323057
Log: Make Phd_PEAR closer to generating valid HTML5. This also removes a few unnecessary overriden methods in Package_PEAR_XHTML that caused e.g. missing attributes for table-related tags (see bug #54208)
 [2012-04-06 14:53 UTC] bjori@php.net
-Status: Open +Status: Feedback
 [2012-04-06 14:53 UTC] bjori@php.net
Is this then fixed?
 [2012-04-06 14:55 UTC] avb@php.net
-Status: Feedback +Status: Closed
 [2012-04-06 14:55 UTC] avb@php.net
Yes. Sorry, forgot to close this.
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Tue Aug 29 15:01:52 2017 UTC