php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #53792 windows.php.net download page, archive link (svn diff and file appended)
Submitted: 2011-01-19 17:21 UTC Modified: 2011-01-20 19:42 UTC
From: harlequin2 at gmx dot de Assigned: kalle (profile)
Status: Closed Package: Website problem
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
 [2011-01-19 17:21 UTC] harlequin2 at gmx dot de
Description:
------------
As requested on the internals mailing list, here's the modified download page for windows.php.net. A new box with a link to the currently selected version's release archive page (releases/qa/snapshots) will be appended to the bottom of the list. I also started to add some notes to the code (i.e. closing bracket comments), but the page should definitely be cleaned up a lot more to make future changes easier.

Regards, Sascha Meyer

--- SVN diff ----

# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
--- Ausgangspunkt (BASE)
+++ Lokal geƤndert (ausgehend von LOCAL)
@@ -21,6 +21,7 @@
 $baseurl = '/' . $dir_to_parse . '/';
 
 $versions = generate_listing($dir_to_parse, $snaps);
+
 $major_order = array('5.3', '5.2', '6.0');
 $minor_order = array(
 		'5.2' => array(
@@ -69,7 +70,7 @@
                             <div class="adv-block"><!-- .adv-block -->
                                 <span class="corners-top"><span></span></span>
                                 
-                                <div class="info entry"><!-- .info -->
+                                <div class="info entry"><!-- .info (release dropdown box) -->
                                     <h2 name="top" id="top"><?php echo $title_page; ?></h2>
                                     
                                     <select onchange="window.location.hash=this.options[this.selectedIndex].value">
@@ -103,7 +104,7 @@
 </div><span class="corners-bottom"><span></span></span></div>
 <?php
 		continue;
-	}
+	} // END if (!isset($versions[$major])) ...
 ?>
 	<p><a href="<?php echo $baseurl . $versions[$major]['source']['path']; ?>">Download source code</a> [<?php echo $versions[$major]['source']['size']; ?>]</p>
 
@@ -117,10 +118,8 @@
 
 <?php
 	foreach ($minor_order[$major] as $minor) { 
+    if (isset($versions[$major][$minor])) {
 ?>
-
-<?php if (isset($versions[$major][$minor])) {
-?>
 		<div class="innerbox">
 		<span class="corners-top"><span></span></span>
 
@@ -166,18 +165,31 @@
 			</div><!-- innerbox -->
 
 	<?php
-	}
+      } // END if (isset($versions[$major][$minor]))
+		} // END foreach ($minor_order[$major] ...
 	?>
-	<?php
-		}
-	?>
 		</div>
 		<span class="corners-bottom"><span></span></span>
 		</div> <!-- block -->
 	<?php 
-	}
+	} // END foreach ($major_order ...
 	?>
 
+    <div class="block">
+      <span class="corners-top"></span>               
+        
+      	<div class="info entry">
+          <h3 id="php-archive" name="php-archive" class="summary entry-title">Browse archive</h3>
+          <div class="innerbox">
+            <span class="corners-top"><span></span></span>
+          <a href="<?php print $baseurl = '/' . $dir_to_parse . '/'; ?>"><?php print $title_page;?></a>
+          <span class="corners-bottom"></span>
+        </div>
+        <span class="corners-bottom"></span>
+        </div>
+    </div>
+
+
 				    <p class="t-center">
 				    </p>
 				</div> <!-- .content -->



Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-01-19 21:11 UTC] bjori@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: kalle
 [2011-01-19 21:11 UTC] bjori@php.net
I don't have windowsweb karma.. Kalle; could you check this out?
 [2011-01-20 19:12 UTC] kalle@php.net
Automatic comment from SVN on behalf of kalle
Revision: http://svn.php.net/viewvc/?view=revision&amp;revision=307632
Log: Implemented FR #53792 (winweb browse archive link)
 [2011-01-20 19:13 UTC] kalle@php.net
-Status: Assigned +Status: Closed
 [2011-01-20 19:13 UTC] kalle@php.net
This bug has been fixed in SVN. Since the websites are not directly
updated from the SVN server, the fix might need some time to spread
across the globe to all mirror sites, including PHP.net itself.

Thank you for the report, and for helping us make PHP.net better.

I added the archive link, however I took abit different approach than your diff and added it as a sidebar widget/box instead which I think is better suited for such meta information.
 [2011-01-20 19:42 UTC] harlequin2 at gmx dot de
Thank you for your work and for implementing the missing feature so fast, your approch sounds good and I'm looking forward to see your modification soon!
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Tue Dec 03 20:01:30 2024 UTC