php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #52679 Content-length header is limited to 32bit integer
Submitted: 2010-08-23 21:24 UTC Modified: 2010-08-24 13:32 UTC
Votes:8
Avg. Score:4.5 ± 0.7
Reproduced:8 of 8 (100.0%)
Same Version:4 (50.0%)
Same OS:1 (12.5%)
From: dominic dot benson at thirdlight dot com Assigned: pajoye
Status: Assigned Package: Apache2 related
PHP Version: 5.3.3 OS: Linux 32
Private report: No CVE-ID:
Have you experienced this issue?
Rate the importance of this bug to you:

 [2010-08-23 21:24 UTC] dominic dot benson at thirdlight dot com
Description:
------------
As per #51723, the content-length header is limited to 2GB - however it need not be.
If Apache 2.2 is built with -DLARGEFILE_SOURCE -DFILE_OFFSET_BITS=64 then apr_off_t is an off64_t, however the conversion in the calls to ap_set_content_length uses strtocol (hence limited to the 32-bit long on Linux 32), but if strtocoll is used instead to return a 64-bit long long, the header is set correctly for values > 2GB.

The attached patch is of the adjustment, I guess the configure script generation needs to be updated to establish whether apr_off_t is long or long long.

Test script:
---------------
<?php
header("Content-Length: 10000000000");
?>


Expected result:
----------------
A header:
Content-Length: 10000000000

Actual result:
--------------
A header:
Content-Length: 2147483647

Patches

big-content-length.patch (last revision 2010-08-23 19:48 UTC) by dominic dot benson at thirdlight dot com)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-08-23 21:49 UTC] dominic dot benson at thirdlight dot com
Correction to the above - clearly I mean strtol and strtoll rather than strtocol and strtocoll.
 [2010-08-24 13:17 UTC] johannes@php.net
strtoll is not portable. We need something like in http://lxr.php.net/opengrok/xref/PHP_5_3/ext/date/lib/parse_date.re#36 to define it. Probably php-src/main/ should declare a php_strtoll or so. (Didn't take a closer look at the issue)
 [2010-08-24 13:32 UTC] pajoye@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: pajoye
 [2010-08-24 13:32 UTC] pajoye@php.net
Exactly, will add it while testing the other fix (which works on windows 32/64 and linux 64 only so far) more carefully.
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Tue Aug 29 15:01:52 2017 UTC