php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #52316 Macro redefinition with Visual Studio 2010
Submitted: 2010-07-12 16:19 UTC Modified: 2010-07-13 10:38 UTC
From: hendrik dot schmieder at jedox dot com Assigned: pajoye (profile)
Status: Wont fix Package: Compile Warning
PHP Version: 5.2.13 OS: Windows
Private report: No CVE-ID: None
View Developer Edit
 [2010-07-12 16:19 UTC] hendrik dot schmieder at jedox dot com 
Description:
------------
With Visual Studio 2010 you get the warning.

...\tsrm\readdir.h(10): warning C4005: '_WIN32_WINNT' : macro redefinition
          C:\Programme\Microsoft SDKs\Windows\v7.0A\include\sdkddkver.h(197) : see previous definition of '_WIN32_WINNT'



Changing in readdir.h

#define _WIN32_WINNT 0x0400

to

#ifndef _WIN32_WINNT
#define _WIN32_WINNT 0x0400
#endif

would solve the problem.

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-07-12 16:29 UTC] pajoye@php.net
-Status: Open +Status: Feedback -Assigned To: +Assigned To: pajoye
 [2010-07-12 16:29 UTC] pajoye@php.net 
Is it not fixed already in 5.3?
 [2010-07-13 09:36 UTC] hendrik dot schmieder at jedox dot com
-Status: Feedback +Status: Assigned
 [2010-07-13 09:36 UTC] hendrik dot schmieder at jedox dot com 
I speak about 5.2.x and in 5.2.14RC2 it is still not fixed.
 [2010-07-13 09:38 UTC] pajoye@php.net
-Status: Assigned +Status: Feedback
 [2010-07-13 09:38 UTC] pajoye@php.net 
Let me rephrase: 5.2 supports only VC6.

That means you can try with 5.3 (which should be fixed).
 [2010-07-13 10:06 UTC] hendrik dot schmieder at jedox dot com
-Status: Feedback +Status: Assigned
 [2010-07-13 10:06 UTC] hendrik dot schmieder at jedox dot com 
There was never a problem compiling php extensions with VS2003 and VS2005 and php version < 5.3.
For PHP we use the supplied binaries.

Why is it so difficult to made the proposed change.
This can be done in less than one minute.
Just for the upcoming 5.2.14 version.
 [2010-07-13 10:18 UTC] pajoye@php.net
-Status: Assigned +Status: Wont fix
 [2010-07-13 10:18 UTC] pajoye@php.net 
5.2 never worked with recent compilers. We do not support them either.

5.3 supports both VC6 and more recent compilers (we use VC9 and test with VC10). Next major version will support only one (be 5.3 or 6.0).

5.2.14 is in RC phase (last one) and only very critical changes can be applied.
 [2010-07-13 10:33 UTC] hendrik dot schmieder at jedox dot com 
I wonder, why there's a bug reporting system, if you don't care for the bugs,
even if the bug can easily be fixed like this one.
 [2010-07-13 10:38 UTC] pajoye@php.net 
What are you talking about? You ask something that we can't fix at this stage. I don't think it is so hard to understand (last RC and only critical fixes go to 5.2 from now on). We also always claimed, advertised and documented that the only compiler we support for 5.2 is VC6.

Now, about windows and php, if you are serious about that, then I strongly suggest you to move to 5.3. Windows support is much better with 5.3, regular updates for the libraries, better portability, faster, more stable. And it supports modern VC versions.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Dec 21 12:01:31 2024 UTC