php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #52124 [strpos] Limit search inside $haystack by new $length parameter
Submitted: 2010-06-19 12:13 UTC Modified: 2021-03-16 14:51 UTC
Votes:6
Avg. Score:3.8 ± 0.7
Reproduced:5 of 5 (100.0%)
Same Version:3 (60.0%)
Same OS:3 (60.0%)
From: vovan-ve at yandex dot ru Assigned:
Status: Suspended Package: Strings related
PHP Version: Irrelevant OS:
Private report: No CVE-ID: None
 [2010-06-19 12:13 UTC] vovan-ve at yandex dot ru
Description:
------------
Why strpos() does not accept $length parameter with addition to $start? It would be very useful to search a $needle inside a part of $haystack sometimes. Now such behaviour can be made by combination with substr():

  $string = 'The big string [with some data here] and with more data there';
  // searh inside substring from offset 16 with length 19
  $tmp = substr($string, 16, 19);
  // now real search
  $pos = strpos($tmp, 'data');
  if (false !== $pos) $pos += 16; // original position
  var_dump($pos);

It work, but not optimal due to redundant copy of substring. I don't need this copy, I just want to reduce searching area.

Test script:
---------------
$string = 'The big string [with some data here] and with more data there';
// search 'data' inside substring from offset 16 with length 19
$pos = strpos($string, 'data', 16, 19);
var_dump($pos);

Expected result:
----------------
int(26)


Patches

Pull Requests

Pull requests:

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-07-26 17:53 UTC] cmb@php.net
I have some doubts that this functionality is required often
enough to warrant adding it to PHP, considering that it can easily
be implemented in userland (without making a copy of the string):

    function strpos_len($haystack, $needle, $offset, $length) {
        $pos = strpos($haystack, $needle, $offset);
        if ($pos > $offset + $length - strlen($needle)) {
            $pos = false;
        }
        return $pos;
    }
 [2015-07-28 16:01 UTC] vovan-ve at yandex dot ru
Yes, it can be implemented in userland, but in that manner it will scan whole string upto the very end instead of early fail.

It's very rate sutiation where the FR is really needed with respect to tonns of data per millisecond. Just ignore this FR.
 [2021-03-16 14:51 UTC] cmb@php.net
-Status: Open +Status: Suspended
 [2021-03-16 14:51 UTC] cmb@php.net
> Yes, it can be implemented in userland, but in that manner it
> will scan whole string upto the very end instead of early fail.

Ah, right!

Anyhow, I think this feature would need an RFC, or at least some
discussion on the internals mailing list.  If anybody is still
interested in this, please pursue the RFC process[1].  For the
time being, I suspend this ticket.

[1] <https://wiki.php.net/rfc/howto>
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Nov 07 16:01:31 2024 UTC