php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #51943 Several files are out of ANSI spec
Submitted: 2010-05-28 17:08 UTC Modified: 2010-07-14 02:05 UTC
From: CoreyStup at gmail dot com Assigned: kalle
Status: Closed Package: Compile Failure
PHP Version: 5.2.13 OS: AIX
Private report: No CVE-ID:
 [2010-05-28 17:08 UTC] CoreyStup at gmail dot com
Description:
------------
Using a native compiler on AIX, several files are not ANSI compliant and won't compile.

ext/pdo/php_pdo_driver.h, trailing commas are not allowed in enums.

ext/hash/php_hash_tiger.h, bitfields must be defined as type int, unsigned int, 
or signed int.   char is not allowed.

ext/date/lib/parse_date.c, uchar already defined conflict. I'm not sure what the correct fix is.  AIX already has uchar defined in sys/types.h:
/usr/include/sys/types.h:typedef        unsigned char   uchar_t;
/usr/include/sys/types.h:typedef        uchar_t         uchar;






Patches

5212patch (last revision 2010-05-28 15:08 UTC) by CoreyStup at gmail dot com)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-06-21 07:49 UTC] kalle@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: kalle
 [2010-06-21 07:49 UTC] kalle@php.net
The parse_date.c one is quite easy too, its just a matter of:

#ifndef _AIX
typedef ...
#endif

Since parse_date.c also defines uchar to unsigned char, im assigning this bug to myself and see if i can get my sparse co working and ill commit this
 [2010-07-14 01:59 UTC] kalle@php.net
Automatic comment from SVN on behalf of kalle
Revision: http://svn.php.net/viewvc/?view=revision&revision=301252
Log: Fixed bug #51943 (Several files are out of ANSI spec)

# Based on patch by CoreyStup at gmail dot com
 [2010-07-14 02:04 UTC] kalle@php.net
Automatic comment from SVN on behalf of kalle
Revision: http://svn.php.net/viewvc/?view=revision&revision=301253
Log: Update the re2c files aswell (bug #51943)
 [2010-07-14 02:05 UTC] kalle@php.net
-Status: Assigned +Status: Closed
 [2010-07-14 02:05 UTC] kalle@php.net
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

Fixed in the latest RC for both 5.2 and 5.3
 
PHP Copyright © 2001-2014 The PHP Group
All rights reserved.
Last updated: Wed Apr 23 14:02:33 2014 UTC