php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #51740 acinclude.m4 macro PHP_CHECK_SIZEOF is not properly quoted
Submitted: 2010-05-04 16:10 UTC Modified: 2010-05-05 23:57 UTC
Votes:1
Avg. Score:2.0 ± 0.0
Reproduced:0 of 1 (0.0%)
From: dave dot mulford at gmail dot com Assigned: felipe (profile)
Status: Closed Package: Compile Warning
PHP Version: 5.3SVN-2010-05-04 (snap) OS: gentoo linux 2.6.30
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2010-05-04 16:10 UTC] dave dot mulford at gmail dot com 
Description:
------------
When building an extension I've written, aclocal displays a warning that the 
macro PHP_CHECK_SIZEOF is "underquoted." I have confirmed this by checking line 
1098 of the acinclude.m4 file that gets copied after phpize is run. 

According to the autoconf documentation, all macros should be surrounded by 
quotes. http://www.gnu.org/software/autoconf/manual/autoconf.html#Macro-
Definitions

Expected result:
----------------
No warnings should be displayed when the aclocal command is executed.

Actual result:
--------------
acinclude.m4:1098: warning: underquoted definition of PHP_CHECK_SIZEOF
acinclude.m4:1098:   run info '(automake)Extending aclocal'
acinclude.m4:1098:   or see 
http://sources.redhat.com/automake/automake.html#Extending-aclocal

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-05-04 16:14 UTC] dave dot mulford at gmail dot com 
I could not get the system to allow me to upload my patch file, so here it is, 
in plain text.

--- acinclude.m4.original       2010-05-04 13:48:26.000000000 +0000
+++ acinclude.m4        2010-05-04 13:48:37.000000000 +0000
@@ -1095,7 +1095,7 @@
 dnl
 dnl PHP_CHECK_SIZEOF(type, cross-value, extra-headers)
 dnl
-AC_DEFUN(PHP_CHECK_SIZEOF, [
+AC_DEFUN([PHP_CHECK_SIZEOF], [
   AC_MSG_CHECKING([size of $1])
   _PHP_CHECK_SIZEOF($1, $2, $3, [
     AC_DEFINE_UNQUOTED([SIZEOF_]translit($1,a-z,A-Z_), [$]php_cv_sizeof_[]$1, 
[Size of $1])
 [2010-05-05 23:55 UTC] felipe@php.net 
Automatic comment from SVN on behalf of felipe
Revision: http://svn.php.net/viewvc/?view=revision&revision=299035
Log: - Fixed bug #51740 (acinclude.m4 macro PHP_CHECK_SIZEOF is not properly quoted)
  Patch by: dave dot mulford at gmail dot com
 [2010-05-05 23:57 UTC] felipe@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: felipe
 [2010-05-05 23:57 UTC] felipe@php.net 
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

Thanks for the patch! ;)
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Fri Apr 19 17:01:30 2024 UTC