|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2010-02-17 14:39 UTC] pedro dot laguna at pentura dot com
Description:
------------
glob:// wrapper doesn't support current queries like glob://*
Reproduce code:
---------------
<?php
$it = new DirectoryIterator("glob://*");
foreach($it as $f) {
printf("%s: %.1FK<br />", $f->getFilename(), $f->getSize()/1024);
}
?>
Expected result:
----------------
tree.php: 1.0K
findregex.php: 0.6K
findfile.php: 0.7K
dba_dump.php: 0.9K
nocvsdir.php: 1.1K
phar_from_dir.php: 1.0K
ini_groups.php: 0.9K
directorytree.php: 0.9K
dba_array.php: 1.1K
class_tree.php: 1.8K
Actual result:
--------------
PHP Fatal error: Uncaught exception 'RuntimeException' with message 'SplFileInfo::getSize(): stat failed for /tree.php' in /home/pedro/public_html/glob.php:7
Stack trace:
#0 /home/pedro/public_html/glob.php(7): SplFileInfo->getSize()
#1 {main}
thrown in /home/pedro/public_html/glob.php on line 7
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Wed Oct 29 21:00:01 2025 UTC |
Hold up a sec, Jani. That's pretty much the example in the manual for the glob:// wrapper, just without a relative path, and it should work. I suspect this is going to end up with Marcus, since he implemented glob:// in the first place, but in the meantime, OP, can you try the following script and confirm that it doesn't throw an exception (and prints the file names in the current directory)? Thanks. <?php $it = new DirectoryIterator("glob://*"); foreach($it as $f) { printf("%s<br />", $f->getFilename()); } ?>OK, strike my last patch, since it was only half of the solution. This is really two bugs for the price of one. The first problem is that globs without a path (such as glob://*) always had a / prepended to their file name within spl_filesystem_object_get_file_name(), which caused the problem in this bug: that a relative foo.txt was resulting in a call to stat("/foo.txt"), which was obviously wrong. The second problem is in the glob wrapper itself. php_glob_stream_path_split() had an off-by-one error that meant that glob patterns within the root directory resulted in an empty path string, just the same as a relative glob. This was being partially masked by the first problem, since the automatic prepending meant that globbing the root directory worked more or less by accident. I've added a phpt file for the reported issue. I'm unsure of the best way to attack testing iterating over the root directory in a platform-independent manner; this may be worth someone with more familiarity writing a test for this case (ie creating a DirectoryIterator with glob:///* on platforms where it makes sense and seeing if the results look vaguely sensible). So, the patches, (hopefully) ready for review and application: Against PHP_5_3: http://www.adamharvey.name/patches/bug-51068-5.3.patch Against trunk: http://www.adamharvey.name/patches/bug-51068-trunk.patch