php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #49599 file eol lost with svn migration
Submitted: 2009-09-19 08:55 UTC Modified: 2011-09-26 23:29 UTC
From: glen at delfi dot ee Assigned: tyrael (profile)
Status: Closed Package: Testing related
PHP Version: 5.2.11 OS:
Private report: No CVE-ID: None
 [2009-09-19 08:55 UTC] glen at delfi dot ee
Description:
------------
for the http://bugs.php.net/36459  ...

seems the \r\n is lost with the cvs -> svn migration. i.e the test file has now native eol

$ file php-5.2.11/ext/session/tests/bug36459.phpt
tests/bug36459.phpt: ASCII text

$ unix2dos tphp-5.2.11/ext/session/ests/bug36459.phpt
unix2dos: converting file tests/bug36459.phpt to DOS format ...

$ file php-5.2.11/ext/session/tests/bug36459.phpt
tests/bug36459.phpt: ASCII text, with CRLF line terminators


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2009-09-19 08:59 UTC] glen at delfi dot ee
to fix the eol style such svn command can do:

$ svn propset svn:eol-style CRLF 
property 'svn:eol-style' set on 'bug36459.phpt'

$ svn commit ...
 [2011-09-26 23:12 UTC] tyrael@php.net
-Status: Open +Status: Closed -Assigned To: +Assigned To: tyrael
 [2011-09-26 23:12 UTC] tyrael@php.net
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.

 For Windows:

http://windows.php.net/snapshots/
 
Thank you for the report, and for helping us make PHP better.

it was fixed http://svn.php.net/viewvc/php/php-
src/trunk/ext/session/tests/bug36459.phpt?r1=242949&r2=260240
 [2011-09-26 23:28 UTC] tyrael@php.net
Automatic comment from SVN on behalf of tyrael
Revision: http://svn.php.net/viewvc/?view=revision&revision=317363
Log: fix #49599, the eol-style is important here, as this is a regression test for #36459
 [2011-09-26 23:29 UTC] tyrael@php.net
no, it wasn't, but I just did now http://svn.php.net/viewvc?
view=revision&revision=317363
 [2011-09-26 23:29 UTC] tyrael@php.net
-Package: Systems problem +Package: Testing related
 [2012-04-18 09:48 UTC] laruence@php.net
Automatic comment on behalf of tyrael
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d1d6911949a86139b6f8e14e02b2149e071c4aea
Log: fix #49599, the eol-style is important here, as this is a regression test for #36459
 [2012-07-24 23:39 UTC] rasmus@php.net
Automatic comment on behalf of tyrael
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d1d6911949a86139b6f8e14e02b2149e071c4aea
Log: fix #49599, the eol-style is important here, as this is a regression test for #36459
 [2013-11-17 09:36 UTC] laruence@php.net
Automatic comment on behalf of tyrael
Revision: http://git.php.net/?p=php-src.git;a=commit;h=d1d6911949a86139b6f8e14e02b2149e071c4aea
Log: fix #49599, the eol-style is important here, as this is a regression test for #36459
 
PHP Copyright © 2001-2019 The PHP Group
All rights reserved.
Last updated: Wed Oct 23 16:01:30 2019 UTC