php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #49007 Add limit option to trim functions
Submitted: 2009-07-21 17:06 UTC Modified: 2016-12-30 14:33 UTC
Votes:4
Avg. Score:4.5 ± 0.9
Reproduced:3 of 3 (100.0%)
Same Version:1 (33.3%)
Same OS:1 (33.3%)
From: jason at jasonsw dot com Assigned:
Status: Open Package: Strings related
PHP Version: * OS: *
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2009-07-21 17:06 UTC] jason at jasonsw dot com
Description:
------------
It would be great if there was a way to limit the amount of characters that were trimmed from a string, in either ltrim, trim or rtrim, using a new limit parameter.

Reproduce code:
---------------
---
From manual page: function.ltrim
---



Patches

feature-49007.diff (last revision 2011-02-27 10:10 UTC) by jthijssen at noxlogic dot nl)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2011-01-01 16:19 UTC] jani@php.net
-Summary: add a third parameter to ltrim: limit +Summary: Add limit option to trim functions -Package: Feature/Change Request +Package: Strings related -Operating System: Debian/Linux +Operating System: * -PHP Version: 5.3.0 +PHP Version: *
 [2011-02-26 21:58 UTC] jthijssen at noxlogic dot nl
I've added a patch (both 5.3 and trunk) for adding a "limit" to the [lr]?trim() functions. 

Using a limit of -1 will trim all (same as without adding the limit)
A limit of 0 does nothing (no trimming)
A positive limit will only trim the amount of chars as specified ON BOTH SIDES. This means using a limit of 2 in trim() will strip max 2 chars from the left and max 2 chars from the right:

trim("   hello   ", " ", 2)  returns " hello ";
ltrim("   hello   ", " ", 2) returns " hello   ";


The only problem to keep it backwards compatible is that you must add the default charlist ( \n\r\t\v\0) in order to use the limit parameter.
 [2016-12-30 14:33 UTC] cmb@php.net
I wonder what would be a use-case for the $limit parameter.
 
PHP Copyright © 2001-2017 The PHP Group
All rights reserved.
Last updated: Sun Nov 19 01:31:42 2017 UTC