|
|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2009-06-29 20:03 UTC] slusarz at curecanti dot org
Description: ------------ There does not seem to be any support for flushing data in a zlib compression stream. Not sure if this is an omission, something obvious that I am missing (and may not be in the documentation), or the fact that the zlib stream filter does not support socket operation. Reproduce code: --------------- $stream = stream_socket_client([...]); // Login to remote server & enable compression remotely (e.g. implementation of IMAP COMPRESS extension - RFC 4978) stream_filter_append($stream, 'zlib.deflate', STREAM_FILTER_WRITE); stream_set_write_buffer($stream, 0); fwrite($stream, 'Testing'); fflush($stream); // tcpdump confirms that nothing is sent from the PHP server to the remote server. Can confirm that upon socket timeout, the pending data is sent. // Similarly, compressed data from incoming stream is not available either. stream_filter_append($stream, 'zlib.inflate', STREAM_FILTER_READ); $in = fread($stream, 8192); // fread() on $stream will timeout. Patcheszlib-filter-flush-fix.patch (last revision 2012-11-02 17:15 UTC by nastasi at alternativeoutput dot it)Pull Requests
Pull requests:
HistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||||||||||||
Copyright © 2001-2024 The PHP GroupAll rights reserved. |
Last updated: Tue Dec 03 16:01:33 2024 UTC |
<?php // 16,000 bytes $text = str_repeat('0123456789abcdef', 1000); $temp = fopen('php://temp', 'r+'); stream_filter_append($temp, 'zlib.deflate', STREAM_FILTER_WRITE); fwrite($temp, $text); rewind($temp); fpassthru($temp); print "Location: " . ftell($temp) . "\n"; fclose($temp); // Expected: compressed data; Location = some non-zero integer // Actual: No data output; Location = 0Verified this with PHP 5.4.7 on Windows. Another reproduce case: ----------------------- <?php $stream = fopen('data://text/plain;base64,' . base64_encode('Foo bar baz'), 'r'); stream_filter_append($stream, 'zlib.deflate', STREAM_FILTER_READ); print bin2hex(stream_get_contents($stream)); Expected: --------- 73cbcf57484a2c02e22a00 // == bin2hex(gzdeflate('Foo bar baz')) Actual: ------- // (empty) Variations tried: ----------------- - Replacing the 'zlib.deflate'-filter by another stream filter ('string.rot13') gives the correct output. - Replacing the 'data://'-URL by a 'file://'- or 'http://'-URL pointing to the same data gives the correct output. - Replacing the 'data://'-URL by a 'php://memory' or 'php://temp' stream to which the data has been written (and the stream rewinded) gives empty outputI had worked on the php source code and found a fix. To understand what happens I had traced what happens during a .... for ($i = 0 ; $i < 3 ; $i++) { fwrite($s[0]); fread($s[1]); fflush($s[0]); fread($s[1]); } loop and I found that the `deflate` function is never called with the `Z_SYNC_FLUSH` flag set because no new data are present into the `backets_in` brigade. My fix is to manage the `PSFS_FLAG_FLUSH_INC` case `AND` no iterations are performed on deflate function extending the if (flags & PSFS_FLAG_FLUSH_CLOSE) { managing `FLUSH_INC` too: if (flags & PSFS_FLAG_FLUSH_CLOSE || (flags & PSFS_FLAG_FLUSH_INC && to_be_flushed)) { All my work is performed on Debian squeeze 6.0.5, and PHP 5.3.3-7+squeeze14 but I already check the current git version and it seems not changed for the essetial parts.