php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #45456 _WIN32_WINNT redefined
Submitted: 2008-07-08 13:46 UTC Modified: 2008-08-14 23:30 UTC
From: Keisial at gmail dot com Assigned: pajoye (profile)
Status: Closed Package: Compile Warning
PHP Version: 5.3CVS-2008-07-08 (snap) OS: Windows
Private report: No CVE-ID: None
View Developer Edit
 [2008-07-08 13:46 UTC] Keisial at gmail dot com 
Description:
------------
_WIN32_WINNT macro can be defiend before including windows headers to specify the minimun windows nt version to support (usually to unhide prototypes not available on previous versions).

It is used like this on TSRM/readdir.h before including windows.h
So far, so good.

However, due to include order, windows.h is already included before, defining _WIN32_WINNT by itself and thus it doesn't do anything. So the define should either be removed (if it's not needed), or moved before.

Reproduce code:
---------------
_WIN32_WINNT is defined on TSRM/readdir.h:10:
main/php.h:405->TSRM/tsrm_virtual_cwd.h:55->readdir.h

windows.h was already included by:
main/php.h:34->Zend/zend.h:53->zend_config.w32.h:39
(in fact winsock2.h at zend_config.w32.h:38 is already including it before the real one)

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2008-07-08 14:40 UTC] johannes@php.net 
Pierre, you're working on Windows stuff these days, please have a look, thanks.
 [2008-07-13 00:01 UTC] pajoye@php.net 
The patch here:

http://news.php.net/php.internals.win/45

fixes this problem, should be committed soon.
 [2008-08-14 23:30 UTC] kalle@php.net 
This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

Last _WIN32_WINNT redefs are now gone and is committed to both PHP_5_3 and HEAD
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Dec 21 15:01:29 2024 UTC