php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #43948 IMAP: Add imap_myrights() function
Submitted: 2008-01-27 22:46 UTC Modified: 2013-02-18 00:33 UTC
Votes:4
Avg. Score:4.2 ± 0.8
Reproduced:4 of 4 (100.0%)
Same Version:0 (0.0%)
Same OS:2 (50.0%)
From: diegows at xtech dot com dot ar Assigned: pajoye (profile)
Status: No Feedback Package: IMAP related
PHP Version: trunk OS:
Private report: No CVE-ID: None
Have you experienced this issue?
Rate the importance of this bug to you:

 [2008-01-27 22:46 UTC] diegows at xtech dot com dot ar
Description:
------------
I suggest that imap_myrights() function should be added to IMAP extension. It's already implemented in uw-imap and it's useful.

Suggested patch:

http://www.woitasen.com.ar/php-myrights.patch



Patches

imap_annotation.patch (last revision 2010-07-30 11:51 UTC by mkoppanen@php.net)
imap_myrights.patch (last revision 2010-07-29 08:48 UTC by mkoppanen@php.net)

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2008-02-14 22:56 UTC] jani@php.net
Reclassified. And please don't change the summary again.
 [2008-08-21 01:33 UTC] diegows at xtech dot com dot ar
Please, use the version I sent to internals mailing list. The previous one has a memory corruption bug.

http://marc.info/?l=php-internals&m=121928000026493&w=2
 [2010-07-28 12:45 UTC] clint at ubuntu dot com
The original patches suggested have been maintained by the kolab project, all the 
way up to v5.3.2. I'd like to suggest that this (very old) bug be patched into 
PHP, so that users can benefit from the additional functionality.

This link includes the patch for myrights at v5.3.2, which I imagine should apply 
fairly cleanly to the latest svn version as well:

http://kolab.org/cgi-bin/viewcvs-kolab.cgi/server/php/patches/php-5.3.2/
 [2010-07-28 20:17 UTC] mkoppanen@php.net
-Package: Feature/Change Request +Package: *General Issues
 [2010-07-28 20:17 UTC] mkoppanen@php.net
Looking at the myrights patch:

+	/* set the callback for the GET_ACL function */
+	mail_parameters(NIL, SET_MYRIGHTS, (void *) mail_myrights);

Should this be 'GET_MYRIGHTS' as the function is used for getting the rights? 

Slightly updated version of the patch http://valokuva.org/~mikko/imap_myrights.patch. Does this work as expected?
 [2010-07-29 10:04 UTC] pajoye@php.net
-Status: Open +Status: Feedback -Assigned To: +Assigned To: pajoye
 [2010-07-29 10:04 UTC] pajoye@php.net
Please attach the patches to this bug, between the versions posted on the list and the ones in external sites, it is hard to track the changes.

I'll back at work next week and will review&test the patch, and surely apply it if there is no issue left.
 [2010-07-29 10:06 UTC] pajoye@php.net
-Package: *General Issues +Package: IMAP related -Operating System: Linux +Operating System: -PHP Version: 5.2.5 +PHP Version: trunk
 [2010-07-29 10:06 UTC] pajoye@php.net
Change category and move to trunk for now, will be applied&tested there first. If it happens to work well and it will then be applied to 5.3 (if RM ok it too).
 [2010-07-29 10:42 UTC] mkoppanen@php.net
Add A Patch form responds to using @php.net address: "Email address must be valid!".
 [2010-07-29 10:48 UTC] mkoppanen@php.net
The following patch has been added/updated:

Patch Name: imap_myrights.patch
Revision:   1280393307
URL:        http://bugs.php.net/patch-display.php?bug=43948&patch=imap_myrights.patch&revision=1280393307
 [2010-07-29 10:48 UTC] mkoppanen@php.net
The following patch has been added/updated:

Patch Name: imap_annotation.patch
Revision:   1280393332
URL:        http://bugs.php.net/patch-display.php?bug=43948&patch=imap_annotation.patch&revision=1280393332
 [2010-07-29 10:49 UTC] mkoppanen@php.net
Finally! imap_annotation.patch is untested as it doesn't compile with my c-client version.
 [2010-07-29 19:32 UTC] clint at ubuntu dot com
Thanks for taking this on pajoye.

We are tracking this bug in Ubuntu here:

https://bugs.launchpad.net/ubuntu/+source/php5/+bug/610630

As soon as its committed, we'll most likely apply the patches to 5.3.2 or 5.3.3 
for release with Maverick 10.10 to make Kolab function properly.
 [2010-07-29 20:15 UTC] mkoppanen@php.net
It looks like c-client needs to be patched to support annotations:

http://kolab.org/cgi-bin/viewcvs-kolab.cgi/server/patches/imap/

Can't find annotation support in upstream c-client 2007e.
 [2010-07-30 10:28 UTC] pajoye@php.net
Right, c-client needs to be patched. It does not sound too good to me but I would like to add some HAVE_ to the c-client patch for cleaner detection.

I also dropped a mail to the the uw imap mailing list to ask what's the status of this patch (if has been actually proposed, rejected, etc.).
 [2010-07-30 13:51 UTC] mkoppanen@php.net
The following patch has been added/updated:

Patch Name: imap_annotation.patch
Revision:   1280490672
URL:        http://bugs.php.net/patch-display.php?bug=43948&patch=imap_annotation.patch&revision=1280490672
 [2010-07-30 13:51 UTC] mkoppanen@php.net
Updated the annotations patch to add HAVE_IMAP_ANNOTATIONS
 [2010-08-17 16:52 UTC] p at rdus dot de
We tracked the status of the uw imap c-client annotation patch here:

https://issues.kolab.org/merge10

I resubmitted the patch three years ago (http://mailman2.u.washington.edu/pipermail/imap-uw/2007-March/001202.html) and it was stalled as Marc Crispin wanted to wait for the ANNOTATEMORE draft to become a real RFC (http://mailman2.u.washington.edu/pipermail/imap-uw/2007-March/001203.html).

While this has happened in the meantime (http://mailman.rfc-editor.org/pipermail/rfc-dist/2009-February/002184.html) c-client development seems to have ceased in the meantime, too.

For Kolab I'm pretty certain we will switch to the newer Horde_Imap_Client library. I already prepared it with the necessary extensions (https://issues.kolab.org/msg21509).

Horde_Imap_Client seems to run faster than the c-client based code though I have to admit that this is just a result from the simple test script and no solid benchmark.

As Hored_Imap_Client is not really released yet and would make a bunch of other updates necessary for the Kolab server we'd be quite happy though if annotation support would already work with the imap_* functions available within PHP.

I know the situation concerning c-client is messy. Is there anything we can do in order to get the patch accepted?
 [2013-02-18 00:33 UTC] php-bugs at lists dot php dot net
No feedback was provided. The bug is being suspended because
we assume that you are no longer experiencing the problem.
If this is not the case and you are able to provide the
information that was requested earlier, please do so and
change the status of the bug back to "Open". Thank you.
 
PHP Copyright © 2001-2020 The PHP Group
All rights reserved.
Last updated: Wed Oct 21 17:01:23 2020 UTC