php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #42987 Add LSAPI support
Submitted: 2007-10-16 11:13 UTC Modified: 2008-05-12 10:10 UTC
Votes:3
Avg. Score:5.0 ± 0.0
Reproduced:2 of 2 (100.0%)
Same Version:1 (50.0%)
Same OS:1 (50.0%)
From: rick dot martinez at gmail dot com Assigned: johannes (profile)
Status: Closed Package: Feature/Change Request
PHP Version: 5.2.* OS: *
Private report: No CVE-ID: None
 [2007-10-16 11:13 UTC] rick dot martinez at gmail dot com
Description:
------------
It would be great if support for the growing Litespeed web server could 
be included with PHP.  This especially because it's increasingly 
difficult for people to support Litespeed with distributions such as 
Debian which would require you to completely recompile the PHP deb 
packages just to support the server.

I think the server is popular enough to warrant inclusion of their SAPI 
into the PHP core.  Many people are enjoying it and its popularity is 
increasing.

Link to the SAPI:
http://www.litespeedtech.com/packages/lsapi/php-litespeed-4.1.tgz


Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2007-10-16 18:42 UTC] helly@php.net
This can imho go into 5.3 and looks pretty good already. You are however not following our coding standards completely. Read CODING_STYLE. Especially the following:
- keep { on same line if not beginning of a function or structure
- no // comments allowed

Apart from that you could shorten the code a bit by having /* {{{ */ after the function declaration and not on a separate line when not adding comments.

As Johannes is the RM for 5.3 he has to decide about this mostly and finally add the code.
 [2007-10-16 18:45 UTC] rick dot martinez at gmail dot com
Sounds great. I'm not the actual LSAPI maintainer but I'll go ahead and 
make the style changes myself and notify the Litespeed developers about 
it.

Thanks so much! This will make life SO much easier for so many PHP users 
on Litespeed.

Rick
 [2007-10-16 20:02 UTC] johannes@php.net
SAPIs don't need much maintaining but still we need to be sure that somebody cares even in a few years - best would be if the Litespeed guys agree to maintain it inside the PHP tree.

I didn't review the code, yet but, additionally to Marcus's comments I saw that some files use another license than PHP License and other refer to an outdated version. when bundling they should be licensed under the current PHP License 3.01.


 [2008-03-26 20:28 UTC] gwang at litespeedtech dot com
Hi Johannes,

I am the maintainer of LiteSpeed SAPI code.
The code has been checked into PHP CVS under /pecl/litespeed, has been updated to the latest release.

As to the license issue, our LSAPI library are BSD license, according to discussion with Stanislav on PHP-DEV email list, BSD license is not likely a problem. 

I hope it could make into the 5.3 release and I am ready to help with any issues in this regard.

Thanks!
 [2008-05-12 10:10 UTC] johannes@php.net
Fixed already for a while
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Thu Feb 22 11:01:28 2024 UTC