php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #42816 [PATCH] Add support for core and magic constants to error.php
Submitted: 2007-10-01 16:44 UTC Modified: 2021-11-10 16:30 UTC
Votes:17
Avg. Score:3.6 ± 1.6
Reproduced:10 of 11 (90.9%)
Same Version:6 (60.0%)
Same OS:6 (60.0%)
From: aharvey@php.net Assigned:
Status: Analyzed Package: Website problem
PHP Version: Irrelevant OS: Irrelevant
Private report: No CVE-ID: None
 [2007-10-01 16:44 UTC] aharvey@php.net
Description:
------------
The (extremely useful) php.net/$keyword redirect currently doesn't support the array of pre-defined constants available within PHP. This is an extra problem because the manual search typically doesn't return relevant results for many of them: as an example, try <http://php.net/PHP_EOL> -- the right place to go would be <http://php.net/reserved.constants>, but that's not in the list.

I've concocted a patch for error.php to add support for the "core predefined constants" and the magic constants (including __NAMESPACE__, since it looks like we'll be getting that one soon enough), and it's at <http://www.adamharvey.name/stuff/error-constants.diff>. Hard-coding the constants into the manual page moves array probably isn't the best approach, but there's going to need to be an evil-looking list somewhere, I guess.

This patch doesn't address the longer list of "standard predefined constants", but it's a start. If the approach is acceptable (or a better one is recommended), I'll look at cooking up a patch for those as well.


Patches

WzdALfCz (last revision 2024-01-11 15:09 UTC by testing at example dot com)
tsSLAueP (last revision 2023-12-27 15:02 UTC by testing at example dot com)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2007-10-10 11:40 UTC] bjori@php.net
I love the idea, but I really don't want _all_ the constants listed in the error handler - and needing to update the error handler on every new constant...

I however can't come up with better way..
 [2008-11-29 16:40 UTC] kalle@php.net
Couldn't PhD perhaps generate a file with core/standard constants for each time the manual is pushed to the mirrors?
 [2018-07-23 10:22 UTC] kalle@php.net
-Status: Open +Status: Analyzed
 [2018-07-23 10:22 UTC] kalle@php.net
Coming back to this one, perhaps we look into using a database an sqlite database for lookups (I'm pretty sure we have such for indexing), and then a handler to determine where to redirect to based on a lookup so we never have to add new constants. It does also seem more efficient than my initial idea of extending the hack by letting PhD generate a list for php-web.
 [2023-12-27 14:59 UTC] testing at example dot com
The following patch has been added/updated:

Patch Name: tsSLAueP
Revision:   1703689165
URL:        https://bugs.php.net/patch-display.php?bug=42816&patch=tsSLAueP&revision=1703689165
 [2023-12-27 14:59 UTC] testing at example dot com
The following patch has been added/updated:

Patch Name: tsSLAueP
Revision:   1703689166
URL:        https://bugs.php.net/patch-display.php?bug=42816&patch=tsSLAueP&revision=1703689166
 [2023-12-27 14:59 UTC] testing at example dot com
The following patch has been added/updated:

Patch Name: tsSLAueP
Revision:   1703689167
URL:        https://bugs.php.net/patch-display.php?bug=42816&patch=tsSLAueP&revision=1703689167
 [2023-12-27 14:59 UTC] testing at example dot com
The following patch has been added/updated:

Patch Name: tsSLAueP
Revision:   1703689168
URL:        https://bugs.php.net/patch-display.php?bug=42816&patch=tsSLAueP&revision=1703689168
 [2023-12-27 15:01 UTC] testing at example dot com
The following patch has been added/updated:

Patch Name: tsSLAueP
Revision:   1703689307
URL:        https://bugs.php.net/patch-display.php?bug=42816&patch=tsSLAueP&revision=1703689307
 [2023-12-27 15:02 UTC] testing at example dot com
The following patch has been added/updated:

Patch Name: tsSLAueP
Revision:   1703689373
URL:        https://bugs.php.net/patch-display.php?bug=42816&patch=tsSLAueP&revision=1703689373
 [2024-01-11 15:09 UTC] testing at example dot com
The following patch has been added/updated:

Patch Name: WzdALfCz
Revision:   1704985776
URL:        https://bugs.php.net/patch-display.php?bug=42816&patch=WzdALfCz&revision=1704985776
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Sat Oct 05 12:01:27 2024 UTC