php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #32643 update tidy to reflect library change in tidyLoadConfig()
Submitted: 2005-04-09 13:59 UTC Modified: 2018-02-28 17:43 UTC
From: nlopess@php.net Assigned: cmb (profile)
Status: Closed Package: Tidy (PECL)
PHP Version: * OS: *
Private report: No CVE-ID: None
View Add Comment Developer Edit
Welcome! If you don't have a Git account, you can't do anything here.
You can add a comment by following this link or if you reported this bug, you can edit this bug over here.
Block user comment
Status: Assign to:
Package:
Bug Type:
Summary:
From: nlopess@php.net
New email:
PHP Version: OS:

 

 [2005-04-09 13:59 UTC] nlopess@php.net 
Description:
------------
I've made a patch (which is backward compatible with older libraries) to update the tidy extension due to a change in the libtidy function tidyLoadConfig().
The change is described at: http://sourceforge.net/tracker/?func=detail&atid=390963&aid=937271&group_id=27659

The patch: http://livedocs.aborla.net/patch.php?id=php.tidy

Nuno

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2005-04-19 20:39 UTC] nlopess@php.net 
Assigning to the extension maintainer.
 [2005-04-25 22:52 UTC] john@php.net 
Opps... meant to close the other report...

I'm a little skeptical about this patch at first glance because you are changing the behavior from immediately returning to simply throwing a warning and continuing execution. Regardless of if the config file failed at parsing, or the config file failed to load they both should stop execution as far as I would think -- can you give me a reason otherwise?
 [2005-04-26 15:28 UTC] nlopess@php.net 
With the current behaviour, you stop the parsing (i.e. tidy_parse_x()) if the configuration file isnt found *or* there was an error while parsing the config file.
IMHO, this is incorrect, because if you have a typo in the config file you could continue and parse the html.

Even if you decide not to apply that change, you could apply the switch() part to give different errors.
 [2010-12-20 09:53 UTC] jani@php.net
-Package: Feature/Change Request +Package: Tidy
 [2010-12-20 09:54 UTC] jani@php.net
-Operating System: n/a +Operating System: * -PHP Version: 5CVS-2005-04-09 (dev) +PHP Version: *
 [2017-10-24 02:42 UTC] kalle@php.net
-Status: Assigned +Status: Analyzed -Assigned To: john +Assigned To:
 [2018-02-28 17:43 UTC] cmb@php.net
-Status: Analyzed +Status: Closed -Assigned To: +Assigned To: cmb
 [2018-02-28 17:43 UTC] cmb@php.net 
This feature request has "recently" been implemented[1] – closing.

[1] <http://git.php.net/?p=php-src.git;a=commit;h=c26991a9eb850ec9aa4a90c0e7891a0bbf814665>
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu Apr 18 04:01:27 2024 UTC