|  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Request #32643 update tidy to reflect library change in tidyLoadConfig()
Submitted: 2005-04-09 13:59 UTC Modified: 2018-02-28 17:43 UTC
From: Assigned: cmb (profile)
Status: Closed Package: Tidy (PECL)
PHP Version: * OS: *
Private report: No CVE-ID: None
 [2005-04-09 13:59 UTC]
I've made a patch (which is backward compatible with older libraries) to update the tidy extension due to a change in the libtidy function tidyLoadConfig().
The change is described at:

The patch:



Add a Patch

Pull Requests

Add a Pull Request


AllCommentsChangesGit/SVN commitsRelated reports
 [2005-04-19 20:39 UTC]
Assigning to the extension maintainer.
 [2005-04-25 22:52 UTC]
Opps... meant to close the other report...

I'm a little skeptical about this patch at first glance because you are changing the behavior from immediately returning to simply throwing a warning and continuing execution. Regardless of if the config file failed at parsing, or the config file failed to load they both should stop execution as far as I would think -- can you give me a reason otherwise?
 [2005-04-26 15:28 UTC]
With the current behaviour, you stop the parsing (i.e. tidy_parse_x()) if the configuration file isnt found *or* there was an error while parsing the config file.
IMHO, this is incorrect, because if you have a typo in the config file you could continue and parse the html.

Even if you decide not to apply that change, you could apply the switch() part to give different errors.
 [2010-12-20 09:53 UTC]
-Package: Feature/Change Request +Package: Tidy
 [2010-12-20 09:54 UTC]
-Operating System: n/a +Operating System: * -PHP Version: 5CVS-2005-04-09 (dev) +PHP Version: *
 [2017-10-24 02:42 UTC]
-Status: Assigned +Status: Analyzed -Assigned To: john +Assigned To:
 [2018-02-28 17:43 UTC]
-Status: Analyzed +Status: Closed -Assigned To: +Assigned To: cmb
 [2018-02-28 17:43 UTC]
This feature request has "recently" been implemented[1] – closing.

[1] <;a=commit;h=c26991a9eb850ec9aa4a90c0e7891a0bbf814665>
PHP Copyright © 2001-2018 The PHP Group
All rights reserved.
Last updated: Sun Nov 19 01:31:42 2017 UTC