php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #31683 changes to $name in __get($name) override future parameters
Submitted: 2005-01-25 01:50 UTC Modified: 2005-02-02 19:17 UTC
Votes:2
Avg. Score:3.0 ± 1.0
Reproduced:2 of 2 (100.0%)
Same Version:1 (50.0%)
Same OS:0 (0.0%)
From: wagner at bonn dot edu Assigned: dmitry
Status: Closed Package: Scripting Engine problem
PHP Version: 5CVS-2005-02-02 (dev) OS: Gentoo Linux
Private report: No CVE-ID:
 [2005-01-25 01:50 UTC] wagner at bonn dot edu
Description:
------------
Changing $name in __get($name) to e.g. "foo", will cause   
the next call of __get() to use "foo" as the name instead   
of the name of the member-Variable that was actually 
called. 
Only intercepted accesses to variables (e.g. 
$obj->doesnt_exist) seem to be affected, not direct calls 
to __get() (e.g. $obj->__get("whatever") ); 
  
Reproducible with PHP 5.0.3, PHP_5_0 CVS and CVS head (PHP  
5.1 dev).  

Reproduce code:
---------------
<?php 
class testclass { 
  public function __get($name) { 
    echo "$name \n"; 
    $name = "wrong";
  } 
} 

$obj = new testclass(); 

for ($i=1; $i <=3; $i++) { 
  $dummy = $obj->correct; 
}
?> 


Expected result:
----------------
correct   
correct  
correct  
 
The line 
$name = "wrong"; 
should have no effect. 

Actual result:
--------------
correct  
wrong  
wrong  
 

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2005-01-31 11:14 UTC] sebastian at famro dot de
This bug concerns also the Function __set(): 
 
Reproduce code: 
--------------- 
<?php 
class testclass {  
  public function __set($name, $value) {  
    echo "$name = $value\n";  
    $name = "wrong"; 
    $value = 1; 
  }  
}  
 
$obj = new testclass();  
 
for ($i=1; $i <=3; $i++) {  
  $obj->correct = 0;  
} 
?> 
 
Actual result: 
-------------- 
correct = 0 
wrong = 0 
wrong = 0
 [2005-02-02 08:19 UTC] dmitry@php.net
Fixed in CVS (HEAD and PHP_5_0).
 [2005-02-02 19:17 UTC] wagner at bonn dot edu
Fixes work for me, both __get() and __set() in  
PHP_5_0 and HEAD.
 
PHP Copyright © 2001-2014 The PHP Group
All rights reserved.
Last updated: Sat Apr 19 17:01:54 2014 UTC