php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #30388 rename across filesystems loses ownership and permission info
Submitted: 2004-10-11 04:00 UTC Modified: 2004-10-27 14:06 UTC
From: drachma60 at ml1 dot net Assigned: tony2001
Status: Closed Package: Filesystem function related
PHP Version: 4.3.8 OS: FreeBSD
Private report: No CVE-ID:
 [2004-10-11 04:00 UTC] drachma60 at ml1 dot net
Description:
------------
When renaming a file (via the "rename" function) across filesystems, owner, group and permission information will be lost if (a) we are running as root and (b) the file is not owned by root.

Additionally, I suspect that permission information can be lost even if (a) we are not running as root and (b) we are running as the user who owns the file.


Reproduce code:
---------------
<?php

// I am running as root
touch ("/tmp/testfile");
passthru ("ls -l /tmp/testfile");

chown ("/tmp/testfile", "nobody");
chgrp ("/tmp/testfile", "nobody");
chmod ("/tmp/testfile", 0);
passthru ("ls -l /tmp/testfile");

rename ("/tmp/testfile", "/tmp/testfile2");
passthru ("ls -l /tmp/testfile2");

rename ("/tmp/testfile2", "/home/testfile2");
passthru ("ls -l /home/testfile2");

?>


Expected result:
----------------
-rw-r--r--  1 root  wheel  0 Oct 10 18:53 /tmp/testfile
----------  1 nobody  nobody  0 Oct 10 18:53 /tmp/testfile
----------  1 nobody  nobody  0 Oct 10 18:53 /tmp/testfile2
----------  1 nobody  nobody  0 Oct 10 18:53 /home/testfile2


Actual result:
--------------
-rw-r--r--  1 root  wheel  0 Oct 10 18:53 /tmp/testfile
----------  1 nobody  nobody  0 Oct 10 18:53 /tmp/testfile
----------  1 nobody  nobody  0 Oct 10 18:53 /tmp/testfile2
-rw-r--r--  1 root  wheel  0 Oct 10 18:53 /home/testfile2



Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2004-10-11 04:06 UTC] drachma60 at ml1 dot net
(corrected typos in summary line)
 [2004-10-23 13:56 UTC] tony2001@php.net
Well, yes, PHP in this particular case works exactly as `cp`:
linux:/ # touch /tmp/testfile
linux:/ # chown nobody:nobody /tmp/testfile
linux:/ # ls -l /tmp/testfile
-rw-r--r--  1 nobody nobody 0 Oct 23 15:47 /tmp/testfile
linux:/ # cp /tmp/testfile /usr/testfile
linux:/ # ls -l /usr/testfile
-rw-r--r--  1 root root 0 Oct 23 15:47 /usr/testfile

but `mv` preserves permissions and IMO rename() should behave in the same way.

I'll write a patch shortly.
 [2004-10-24 14:00 UTC] tony2001@php.net
Here are the patches:
http://tony2001.phpclub.net/dev/tmp/bug30388.4_3.diff - for 4.3.10-dev
http://tony2001.phpclub.net/dev/tmp/bug30388.diff - for 5.1-dev

Waiting for Wez's response, as he's the maintainer of streams.
 [2004-10-27 14:06 UTC] tony2001@php.net
This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.


 
PHP Copyright © 2001-2014 The PHP Group
All rights reserved.
Last updated: Sun Apr 20 03:02:42 2014 UTC