php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #29160 [PATCH] phpize not automake 1.8 compatible
Submitted: 2004-07-14 20:27 UTC Modified: 2004-12-30 08:03 UTC
Votes:7
Avg. Score:4.1 ± 0.8
Reproduced:5 of 5 (100.0%)
Same Version:3 (60.0%)
Same OS:2 (40.0%)
From: selsky at columbia dot edu Assigned: sniper (profile)
Status: Closed Package: Compile Failure
PHP Version: 4.3.8 OS: Solaris 9
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2004-07-14 20:27 UTC] selsky at columbia dot edu 
Description:
------------
automake 1.8 is more strict about quoting rules according to http://sources.redhat.com/automake/automake.html#Extending%20aclocal

I'm currently trying to build APC 2.0.4 with

automake 1.8.3
autoconf 2.59
libtool 1.5.2

Expected result:
----------------
The module should build as the documentation describes.

Actual result:
--------------
$ phpize 
configure.in:9: warning: underquoted definition of PHP_WITH_PHP_CONFIG
  run info '(automake)Extending aclocal'
  or see http://sources.redhat.com/automake/automake.html#Extending%20aclocal
configure.in:32: warning: underquoted definition of PHP_EXT_BUILDDIR
configure.in:33: warning: underquoted definition of PHP_EXT_DIR
configure.in:34: warning: underquoted definition of PHP_EXT_SRCDIR
configure.in:35: warning: underquoted definition of PHP_ALWAYS_SHARED
acinclude.m4:19: warning: underquoted definition of PHP_PROG_RE2C
configure.in:65: error: possibly undefined macro: AC_PROG_LIBTOOL
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2004-07-14 20:37 UTC] selsky at columbia dot edu 
Here's a patch to correct the warnings:

diff -ur php-4.3.8.orig/acinclude.m4 php-4.3.8/acinclude.m4
--- php-4.3.8.orig/acinclude.m4	2004-07-13 20:28:54.000000000 -0400
+++ php-4.3.8/acinclude.m4	2004-07-14 13:50:11.923691000 -0400
@@ -16,7 +16,7 @@
   sed -e "s#\$(srcdir)#$ac_srcdir#g" -e "s#\$(builddir)#$ac_builddir#g" $src  >> Makefile.fragments
 ])
 
-AC_DEFUN(PHP_PROG_RE2C,[
+AC_DEFUN([PHP_PROG_RE2C],[
   AC_CHECK_PROG(RE2C, re2c, re2c, [exit 0;])
 ])
 
diff -ur php-4.3.8.orig/scripts/phpize.m4 php-4.3.8/scripts/phpize.m4
--- php-4.3.8.orig/scripts/phpize.m4	2004-07-13 20:28:54.000000000 -0400
+++ php-4.3.8/scripts/phpize.m4	2004-07-14 13:51:28.346385000 -0400
@@ -6,7 +6,7 @@
 
 PHP_INIT_BUILD_SYSTEM
 
-AC_DEFUN(PHP_WITH_PHP_CONFIG,[
+AC_DEFUN([PHP_WITH_PHP_CONFIG],[
   AC_ARG_WITH(php-config,
 [  --with-php-config=PATH],[
   PHP_CONFIG=$withval
@@ -29,10 +29,10 @@
   AC_MSG_RESULT($EXTENSION_DIR)
 ])
 dnl
-AC_DEFUN(PHP_EXT_BUILDDIR,[.])dnl
-AC_DEFUN(PHP_EXT_DIR,[""])dnl
-AC_DEFUN(PHP_EXT_SRCDIR,[$abs_srcdir])dnl
-AC_DEFUN(PHP_ALWAYS_SHARED,[
+AC_DEFUN([PHP_EXT_BUILDDIR],[.])dnl
+AC_DEFUN([PHP_EXT_DIR],[""])dnl
+AC_DEFUN([PHP_EXT_SRCDIR],[$abs_srcdir])dnl
+AC_DEFUN([PHP_ALWAYS_SHARED],[
   ext_output="yes, shared"
   ext_shared=yes
   test "[$]$1" = "no" && $1=yes


I'm not sure how to fix the error though.
 [2004-12-30 08:03 UTC] sniper@php.net 
This bug has been fixed in CVS.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Wed May 01 15:01:30 2024 UTC