php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #24017 HTML/Form.php; target missing in returnStart()
Submitted: 2003-06-04 10:09 UTC Modified: 2003-07-31 04:02 UTC
Votes:1
Avg. Score:5.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:1 (100.0%)
Same OS:1 (100.0%)
From: magz at bop dot nu Assigned: ssb
Status: Closed Package: PEAR related
PHP Version: 4.3.2 OS: Linux
Private report: No CVE-ID:
 [2003-06-04 10:09 UTC] magz at bop dot nu
$Id: Form.php,v 1.2 2003/02/14 11:12:08 mj Exp $

The returnStart() function is missing the "target" (its there in funcion start()).

resturnStart() Should look like:

    function returnStart($multipartformdata = false)
    {
        $str = "<form action=\"" . basename ($this->action) . "\" method=\"$this->method\"";
        if ($this->name) {
            $str .= " name=\"$this->name\"";
        }
        if ($this->target) {
            print " target=\"$this->target\"";
        }
        if ($multipartformdata) {
            $str .= " enctype=\"multipart/form-data\"";
        }
        $str .= ">";

        return $str;
    }

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2003-06-04 10:11 UTC] magz at bop dot nu
Sorry, correct is;

function returnStart($multipartformdata = false)
{
    $str = "<form action=\"" . basename ($this->action) . "\" method=\"$this->method\"";
    if ($this->name) {
        $str .= " name=\"$this->name\"";
    }
    if ($this->target) {
        $str .= " target=\"$this->target\"";
    }
    if ($multipartformdata) {
        $str .= " enctype=\"multipart/form-data\"";
    }
    $str .= ">";

    return $str;
}
 [2003-07-31 04:02 UTC] nicos@php.net
This bug has been fixed in CVS.

In case this was a PHP problem, snapshots of the sources are packaged
every three hours; this change will be in the next snapshot. You can
grab the snapshot at http://snaps.php.net/.
 
In case this was a documentation problem, the fix will show up soon at
http://www.php.net/manual/.

In case this was a PHP.net website problem, the change will show
up on the PHP.net site and on the mirror sites in short time.
 
Thank you for the report, and for helping us make PHP better.


 
PHP Copyright © 2001-2014 The PHP Group
All rights reserved.
Last updated: Thu Apr 24 21:01:55 2014 UTC