php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #23983 whereAdd($keywords); accepts blank $keywords
Submitted: 2003-06-03 08:56 UTC Modified: 2003-06-04 20:41 UTC
From: mike dot carter at koa dot uk dot com Assigned:
Status: Closed Package: PEAR related
PHP Version: 4.3.1 OS: Windows XP
Private report: No CVE-ID: None
View Add Comment Developer Edit
 [2003-06-03 08:56 UTC] mike dot carter at koa dot uk dot com 
If I try to do a $dobj->whereAdd($keywords); and $keywords is empty/null then surely DataObjects would be best off just ignoring the request and disgarding it?  Instead it adds an additional "AND" into the query string being built causing an invalid SQL query.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2003-06-04 20:41 UTC] alan_k@php.net 
This bug has been fixed in CVS.

In case this was a PHP problem, snapshots of the sources are packaged
every three hours; this change will be in the next snapshot. You can
grab the snapshot at http://snaps.php.net/.
 
In case this was a documentation problem, the fix will show up soon at
http://www.php.net/manual/.

In case this was a PHP.net website problem, the change will show
up on the PHP.net site and on the mirror sites in short time.
 
Thank you for the report, and for helping us make PHP better.

have added checks to orderby/limit etc. as well.

Thanks, Regards
Alan
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Wed Apr 24 00:01:32 2024 UTC