php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #23203 phpinf() css/xhtml error
Submitted: 2003-04-14 09:57 UTC Modified: 2003-04-21 12:55 UTC
From: cjb at filmnet dot com dot au Assigned:
Status: Not a bug Package: PHP options/info functions
PHP Version: 4.3.0 OS: Mac OS X
Private report: No CVE-ID: None
 [2003-04-14 09:57 UTC] cjb at filmnet dot com dot au
The phpinfo() function generates a web page written to 
the XHTML 1.0 transitional DTD.

This page incorrectly uses the HTML technique of hiding 
CSS styles from "old" browsers useing the "<!-- -->" 
style comments.

The XHTML spec allows user agents to ignore CSS between 
such comments <http://www.w3.org/TR/xhtml1/#C_4> as my 
broswer does.

The end results is I don't get styled markup of php 
info in my browser... which is striclty applying the 
XHTML 1.0 spec.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2003-04-19 14:23 UTC] ken at tossell dot net
It really isn't necessary to comment this out. The diff below removes the <!-- (ext/standard/info.c)
--- info.c-old  Sat Apr 19 15:21:04 2003
+++ info.c      Sat Apr 19 15:19:56 2003
@@ -183,9 +183,9 @@
  */
 void php_info_print_style(void)
 {
-       php_printf("<style type=\"text/css\"><!--\n");
+       php_printf("<style type=\"text/css\">\n");
        php_info_print_css();
-       php_printf("//--></style>\n");
+       php_printf("</style>\n");
 }
 /* }}} */
 [2003-04-21 12:55 UTC] sniper@php.net
Get working browser.

 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved.
Last updated: Sat Apr 27 11:01:30 2024 UTC