PHP :: Bug #20221 :: str

Bug #20221	str_replace
Submitted:	2002-11-02 13:04 UTC	Modified:	2003-06-24 11:49 UTC
From:	panacode at skynet dot be	Assigned:
Status:	Not a bug	Package:	Strings related
PHP Version:	4.2.3	OS:	Linux
Private report:	No	CVE-ID:	None

View Developer Edit

[2002-11-02 13:04 UTC] panacode at skynet dot be

str_replace when used with with arrays,
for every element in the search/replace arrays
a simple replace in the source string (rather than
using an external string) is performed.

This causes an unexpected result like
if one of the replace values includes
a search value it will be replaced in a subsequent
replacing action.

If this is a feature rather than a bug (which I doubt)
please state it in the documentation.

An example:

$vSearch[] = '@gill';
$vSearch[] = '@doubleyou';

$vReplace[] = '@doubleyou';
$vReplace[] = '@bates';

$sSubject = "@gill is my friend";
$sResult = str_replace($vSearch, $vReplace, $sSubject);

echo $sResult; 
// will output "@bates is not my friend" instead
// of "@doubleyou is not my friend"



Best regards,
Eugen Fernea
IT Manager
Panacode Software
rue de la Station, 1/1
7090 Braine-Le-Comte
Belgium
E-mail: panacode@skynet.be
Phone: +32 067/48 58 94
Mobile: +32 (0)472 95 15 48
Web: http://www.panacode.com

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports

[2002-11-02 14:22 UTC] kalowsky@php.net

Please try using this CVS snapshot:

  http://snaps.php.net/php4-latest.tar.gz
 
For Windows:
 
  http://snaps.php.net/win32/php4-win32-latest.zip

[2002-11-02 17:43 UTC] panacode at skynet dot be

Sorry for bothering (and for my writing errors).

There actually is another function in PHP that has the
behaviour that I expect: strtr(str, arr)

$vReplace['@gill'] = '@doubleyou';
$vReplace['@doubleyou'] = '@bates';

$sSubject = "@gill @doubleyou is not my friend";
$sResult = strtr($sSubject, $vReplace);

echo $sResult; 
// will output "@doubleyou @bates is not my friend"

[2002-11-02 17:46 UTC] iliaa@php.net

Sorry, but your problem does not imply a bug in PHP itself.  For a
list of more appropriate places to ask for help using PHP, please
visit http://www.php.net/support.php as this bug system is not the
appropriate forum for asking support questions. 

Thank you for your interest in PHP.

[2003-06-19 16:29 UTC] heinz at hhombergs dot de

Sorry but there is a bug in the str_replace function. Reproduced under 4.2.2 and 4.3.2

function recode_charset($string,$cs_from,$cs_to) {
  $trans_tbl["ASCII"] = array("&", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?", "?");

  $trans_tbl["UNICODE"] = array("&#x26;", "&#161;", "&#162;", "&#163;", "&#164;", "&#165;", "&#166;", "&#167;", "&#168;", "&#169;", "&#170;", "&#171;", "&#172;", "&#173;", "&#174;", "&#175;", "&#176;", "&#177;", "&#178;", "&#179;", "&#180;", "&#181;", "&#182;", "&#183;", "&#184;", "&#185;", "&#186;", "&#187;", "&#188;", "&#189;", "&#190;", "&#191;", "&#192;", "&#193;", "&#194;", "&#195;", "&#196;", "&#197;", "&#198;", "&#199;", "&#200;", "&#201;", "&#202;", "&#203;", "&#204;", "&#205;", "&#206;", "&#207;", "&#208;", "&#209;", "&#210;", "&#211;", "&#212;", "&#213;", "&#214;", "&#215;", "&#216;", "&#217;", "&#218;", "&#219;", "&#220;", "&#221;", "&#222;", "&#223;", "&#224;", "&#225;", "&#226;", "&#227;", "&#228;", "&#229;", "&#230;", "&#231;", "&#232;", "&#233;", "&#234;", "&#235;", "&#236;", "&#237;", "&#238;", "&#239;", "&#240;", "&#241;", "&#242;", "&#243;", "&#244;", "&#245;", "&#246;", "&#247;", "&#248;", "&#249;", "&#250;", "&#251;", "&#252;", "&#253;", "&#254;", "&#255;");

  $trans_tbl["HTML"] = array("&amp;", "&iexcl;", "&cent;", "&pound;", "&curren;", "&yen;", "&brvbar;", "&sect;", "&uml;", "&copy;", "&ordf;", "&laquo;", "&not;", "&shy;", "&reg;", "&macr;", "&deg;", "&plusmn;", "&sup2;", "&sup3;", "&acute;", "&micro;", "&para;", "&middot;", "&cedil;", "&sup1;", "&ordm;", "&raquo;", "&frac14;", "&frac12;", "&frac34;", "&iquest;", "&Agrave;", "&Aacute;", "&Acirc;", "&Atilde;", "&Auml;", "&Aring;", "&AElig;", "&Ccedil;", "&Egrave;", "&Eacute;", "&Ecirc;", "&Euml;", "&Igrave;", "&Iacute;", "&Icirc;", "&Iuml;", "&ETH;", "&Ntilde;", "&Ograve;", "&Oacute;", "&Ocirc;", "&Otilde;", "&Ouml;", "&times;", "&Oslash;", "&Ugrave;", "&Uacute;", "&Ucirc;", "&Uuml;", "&Yacute;", "&THORN;", "&szlig;", "&agrave;", "&aacute;", "&acirc;", "&atilde;", "&auml;", "&aring;", "&aelig;", "&ccedil;", "&egrave;", "&eacute;", "&ecirc;", "&euml;", "&igrave;", "&iacute;", "&icirc;", "&iuml;", "&eth;", "&ntilde;", "&ograve;", "&oacute;", "&ocirc;", "&otilde;", "&ouml;", "&divide;", "&oslash;", "&ugrave;", "&uacute;", "&ucirc;", "&uuml;", "&yacute;", "&thorn;", "&yuml;");

  return str_replace($trans_tbl[$cs_from],  $trans_tbl[$cs_to],  $string);
}

$string = recode_charset('???????','ASCII','HTML');

will produce &Atilde;&atilde;&Ucirc;&ucirc;&Otilde;&otilde;&THORN;

but &Auml;&auml;&Uuml;&uuml;&Ouml;&ouml;&szlig; is correct.

[2003-06-20 10:09 UTC] jay@php.net

In php_str_replace_in_subject(), if a value in the search 
array is of 0 length, the search array internal pointer is 
moved ahead, but not the replace array. Shouldn't they 
both be moved ahead? This would produce the results 
panacode is expecting, but it would break BC, but I don't 
see any documentation that covers this behaviour. Unless 
I'm blind, of course, which I may be. 
 
J

[2003-06-24 11:39 UTC] heinz at hhombergs dot de

But as you can see the search and the replace array in the function have no 0 length values and all three arrays are of the same size.

[2003-06-24 11:49 UTC] jay@php.net

Really? Then what is the value of $trans_tbl['ASCII'][13]? 
That looks zero-length to me.  
 
php_str_replace_in_subject() previously moved the search 
array forward and didn't move the replace array. This has 
since been fixed in CVS. 
 
J

	php.net \| support \| documentation \| report a bug \| advanced search \| search howto \| statistics \| random bug \| login
go to bug id or search bugs for


Copyright © 2001-2024 The PHP Group All rights reserved.	Last updated: Sat Dec 21 13:01:31 2024 UTC