Changes made to the configure script.  Can you please test this later in a little bit with a new snapshot from http://snaps.php.net

Thank you. 

The changed if logic still assumes that it should look for n $PHP_NSAPI/include and then for $PHP_NSAPI/plugins/include ONLY if $PHP_NSAPI/plugins/include did not exist. This is not appropriate logic. Both directories exist.

Check for the existence of the file; don't do an if/else on the directories. If you feel you must do a directory check, look for $PHP_NSAPI/plugins/include first; it would be for the newer version of iPlanet.

It's all very nice to test that including the .h works (or doesn't) but this is inconsequential if you don't first check for the existence of the file.

There is a check for the header file nsapi.h in both sections.  


Also my brief (albiet limited) understanding is that nsapi v4 uses only the plugins/include/ directory, nsapi v3 usrs just the includes directory.  Thus the OR between them.  

Anyways if you can test this patch to the config.m4 (you'll need to run cvsclean and buildconf) I'd appriciate it
Index: config.m4
===================================================================
RCS file: /repository/php4/sapi/nsapi/config.m4,v
retrieving revision 1.12
diff -u -u -r1.12 config.m4
--- config.m4   8 Aug 2002 05:52:15 -0000       1.12
+++ config.m4   14 Aug 2002 00:15:19 -0000
@@ -20,11 +20,13 @@
     NSAPI_INCLUDE=$PHP_NSAPI/include
     AC_MSG_RESULT(Netscape-Enterprise/3.x style)
     AC_CHECK_HEADERS([$NSAPI_INCLUDE/nsapi.h])
-  elif test -d $PHP_NSAPI/plugins/include ; then
-    NSAPI_INCLUDE=$PHP_NSAPI/plugins/include
+  fi
+  if test -d $PHP_NSAPI/plugins/include ; then
+    NSAPI_INCLUDE="$NSAPI_INCLUDE $PHP_NSAPI/plugins/include"
     AC_MSG_RESULT(iPlanet/4.x style)
     AC_CHECK_HEADERS([$NSAPI_INCLUDE/nsapi.h])
-  else
+  fi
+  if test "$NSAPI_INCLUDE" = ""; then
     AC_MSG_ERROR(Please check you have nsapi.h in either $PHP_NSAPI/include or $PHP_NSAPI/plugins/include)
   fi
   PHP_ADD_INCLUDE($NSAPI_INCLUDE)

When I downloaded and tried the php4-200208140000 archive from http://snaps.php.net, the configure script changes there didn't work. The include directory test succeeded; the version is incorrectly determined to be v3; the test for the header file fails (without any noticeable error message!):

...
Configuring SAPI modules
...
checking for NSAPI support... /usr/prop/netscape/server4/
checking for NSAPI include files... Netscape-Enterprise/3.x style
checking for /usr/prop/netscape/server4//include/nsapi.h... no
...
checking for chosen SAPI module... nsapi



and the build fails
cc: Severe: /vb/Ctech/vlbrown/.../nsapi/nsapi.c, line 50: Cannot find file "nsapi.h" specified in #include directive. (noinclfilef)
#include "nsapi.h"
-^
*** Exit 1
Stop.

> There is a check for the header file nsapi.h in both sections.  

Yes, I realize this, although I do believe that a simple test -f would suffice over the cpp stuff I saw in the php4-200208140000 version.


> Also my brief (albiet limited) understanding is 
> that nsapi v4 uses only the plugins/include/ 
> directory, nsapi v3 usrs just the includes
> directory.  Thus the OR between them.  

The problem is, you're half right. V4 _uses_ only the
plugins/include/ directory but it _posesses_ both directories. The includes directory is empty _but it exists_. It's possible that it was installed this way; it's possible that an upgrade from v3 to v4 doesn't remove the includes directory. Whatever the reason, the fact remains that BOTH directories exist. The current if/elif/else logic never looks for plugins/include (let alone plugins/include/nsapi.h) becaause it finds include (although it fails to find include/nsapi.h).

Judging from several of the other bug reports on this same issue, the includes directory (still?) exists for other users at other sites with other installations as well.

> Anyways if you can test...
> you'll need to run cvsclean and buildconf)

We don't use your CVS, but looking at the patch you sent,this is a reasonable change. I applied the changes to the php 4.2.2 configure file; there are no problems finding the include files and the build succeeds as desired.

If this change is committed, I would agreee the bug is fixed.

This bug has been fixed in CVS. You can grab a snapshot of the
CVS version at http://snaps.php.net/. In case this was a documentation 
problem, the fix will show up soon at http://www.php.net/manual/.
In case this was a PHP.net website problem, the change will show
up on the PHP.net site and on the mirror sites.
Thank you for the report, and for helping us make PHP better.

or will be as soon as my cvs commit goes through... Thank you for your time and testing :)