php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login
Bug #10733 configure --disable-short-tags doesn't disable short-tags
Submitted: 2001-05-08 11:20 UTC Modified: 2001-05-08 16:09 UTC
From: jbozza at geocomm dot com Assigned:
Status: Closed Package: PHP options/info functions
PHP Version: 4.0 Latest CVS (2001-05-08) OS: FreeBSD 4.3
Private report: No CVE-ID: None
 [2001-05-08 11:20 UTC] jbozza at geocomm dot com
When configuring PHP4 (confirmed with latest snap from this morning) using the option --disable-short-tags, PHP still enables short tags by default.  Using --enable-short-tags=no works just fine (though this is not available in the --help for configure)

Looking at the configure script, --disable-short-tags is never even checked.

Patches

Add a Patch

Pull Requests

Add a Pull Request

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2001-05-08 11:33 UTC] jbozza at geocomm dot com
Update:
   --enable-short-tags=no doesn't seem to have any effect either.  It sets the define:
   DEFAULT_SHORT_OPEN_TAG 0
in php_config.h, but there doesn't seem to be any code I can find that actually interprets the define.

 [2001-05-08 11:38 UTC] sniper@php.net
You are right. This configure option is not used anywhere.
It should set the builting default to disabled..

You propably know that you can set this in php.ini too
so this is not critical, just annoying.

--Jani

 [2001-05-08 12:53 UTC] jbozza at geocomm dot com
Couldn't this be (quickly) fixed with the following?

--- configure.in.orig   Tue May  8 11:46:10 2001
+++ configure.in        Tue May  8 11:46:24 2001
@@ -589,9 +589,9 @@
 [  --disable-short-tags    Disable the short-form <? start tag by default.],yes)
 
 if test "$PHP_SHORT_TAGS" = "yes"; then
-  AC_DEFINE(DEFAULT_SHORT_OPEN_TAG,1,[ ])
+  AC_DEFINE(DEFAULT_SHORT_OPEN_TAG,"1",[ ])
 else
-  AC_DEFINE(DEFAULT_SHORT_OPEN_TAG,0,[ ])
+  AC_DEFINE(DEFAULT_SHORT_OPEN_TAG,"0",[ ])
 fi

--- main/main.c.orig	Tue May  8 11:46:32 2001
+++ main/main.c	Tue May  8 11:47:12 2001
@@ -202,7 +202,7 @@
 	STD_PHP_INI_BOOLEAN("register_argc_argv",	"1",		PHP_INI_ALL,		OnUpdateBool,			register_argc_argv,		php_core_globals,	core_globals)
 	STD_PHP_INI_BOOLEAN("register_globals",		"1",		PHP_INI_ALL,		OnUpdateBool,			register_globals,		php_core_globals,	core_globals)
 	STD_PHP_INI_BOOLEAN("safe_mode",			"0",		PHP_INI_SYSTEM,		OnUpdateBool,			safe_mode,				php_core_globals,	core_globals)
-	STD_PHP_INI_BOOLEAN("short_open_tag",		"1",		PHP_INI_SYSTEM|PHP_INI_PERDIR,		OnUpdateBool,			short_tags,				zend_compiler_globals,	compiler_globals)
+	STD_PHP_INI_BOOLEAN("short_open_tag",		DEFAULT_SHORT_OPEN_TAG,		PHP_INI_SYSTEM|PHP_INI_PERDIR,		OnUpdateBool,			short_tags,				zend_compiler_globals,	compiler_globals)
 	STD_PHP_INI_BOOLEAN("sql.safe_mode",		"0",		PHP_INI_SYSTEM,		OnUpdateBool,			sql_safe_mode,			php_core_globals,	core_globals)
 	STD_PHP_INI_BOOLEAN("track_errors",			"0",		PHP_INI_ALL,		OnUpdateBool,			track_errors,			php_core_globals,	core_globals)
 	STD_PHP_INI_BOOLEAN("y2k_compliance",		"0",		PHP_INI_ALL,		OnUpdateBool,			y2k_compliance,			php_core_globals,	core_globals)


 [2001-05-08 16:09 UTC] derick@php.net
This is fixed in CVS (by Jani).
 
PHP Copyright © 2001-2021 The PHP Group
All rights reserved.
Last updated: Mon Jan 18 05:01:23 2021 UTC