php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #80310 ext-intl with icu4c 68.1: use of undeclared identifier 'TRUE'
Submitted: 2020-11-03 14:03 UTC Modified: 2020-11-03 15:09 UTC
From: me at derrabus dot de Assigned:
Status: Closed Package: Compile Failure
PHP Version: 7.4.12 OS: macOS 10.15
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: me at derrabus dot de
New email:
PHP Version: OS:

 

 [2020-11-03 14:03 UTC] me at derrabus dot de 
Description:
------------
I tried to build php 7.4.12 with ext-intl against icu4c 68.1 and the compilation fails with the error output below. Downgrading to icu4c 67.1 fixes the problem.

This might be related to this change: https://unicode-org.atlassian.net/browse/ICU-21267

Actual result:
--------------
/path/to/php-7.4.12/ext/intl/collator/collator_sort.c:349:26: error: use of undeclared identifier 'TRUE'
        collator_sort_internal( TRUE, INTERNAL_FUNCTION_PARAM_PASSTHRU );
                                ^
/path/to/php-7.4.12/ext/intl/collator/collator_sort.c:543:26: error: use of undeclared identifier 'FALSE'
        collator_sort_internal( FALSE, INTERNAL_FUNCTION_PARAM_PASSTHRU );
                                ^
2 errors generated.
make: *** [ext/intl/collator/collator_sort.lo] Error 1
make: *** Waiting for unfinished jobs....

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2020-11-03 15:09 UTC] cmb@php.net 
Would it work with

    CFLAGS=-DU_DEFINE_FALSE_AND_TRUE=1
 [2020-11-03 15:34 UTC] me at derrabus dot de 
If I try this, the error is a different one, but it still does not compile.

/path/to/php-7.4.12/ext/intl/timezone/timezone_class.cpp:328:21: error: use of undeclared identifier 'FALSE'
        tz->getOffset(now, FALSE, rawOffset, dstOffset, uec);
                           ^
/path/to/php-7.4.12/ext/intl/timezone/timezone_methods.cpp:98:57: error: use of undeclared identifier 'FALSE'
        tz = timezone_convert_datetimezone(tzobj->type, tzobj, FALSE, NULL,
                                                               ^
 [2020-11-03 16:14 UTC] me at derrabus dot de 
However, it *does* compile if I configure CXXFLAGS the same way.
 [2020-11-03 16:30 UTC] me at derrabus dot de 
Can you have a look at https://github.com/php/php-src/pull/6397 please?
 [2020-11-09 13:36 UTC] nikic@php.net 
Automatic comment on behalf of me@derrabus.de
Revision: http://git.php.net/?p=php-src.git;a=commit;h=8eaaabdd58a395853d3658418622ee24635cb871
Log: Fixed bug #80310: Support for icu4c 68.1.
 [2020-11-09 13:36 UTC] nikic@php.net
-Status: Open +Status: Closed
 [2020-11-13 14:05 UTC] cmb@php.net 
Related To: Bug #80361
 [2022-01-07 09:35 UTC] adiechahari at gmail dot com 
export CXX="g++ -DTRUE=1 -DFALSE=0"
export CC="gcc -DTRUE=1 -DFALSE=0"

Try this, it should work
ref: https://github.com/phpbrew/phpbrew/issues/1236
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sat Nov 23 09:01:28 2024 UTC