php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #69235 Hidef doesn't compile with specified PHP version i.e. 5.6.6
Submitted: 2015-03-13 06:08 UTC Modified: 2017-10-24 16:57 UTC
Votes:1
Avg. Score:5.0 ± 0.0
Reproduced:1 of 1 (100.0%)
Same Version:1 (100.0%)
Same OS:1 (100.0%)
From: me at umakantpatil dot com Assigned:
Status: Suspended Package: hidef (PECL)
PHP Version: 5.6.6 OS: Ubuntu 12.04.5 LTS
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: me at umakantpatil dot com
New email:
PHP Version: OS:

 

 [2015-03-13 06:08 UTC] me at umakantpatil dot com 
Description:
------------
When you compile latest version of Hidef with the PHP v5.6.6, you get an error. Compilation fails.

Expected result:
----------------
A successful compilation and generated module hidef.so

Actual result:
--------------
/home/umakant/hidef/src/frozenarray.c: In function ‘frozen_array_unserialize’:
/home/umakant/hidef/src/frozenarray.c:1085:2: warning: pointer targets in passing argument 3 of ‘php_var_unserialize’ differ in signedness [-Wpointer-sign]
/home/umakant/hidef/dependencies/include/php/ext/standard/php_var.h:53:12: note: expected ‘const unsigned char *’ but argument is of type ‘char *’
[frozenarray.lo]

Patches

New_Fix_type_cast_and_replace_IS_CONSTANT_INDEX_with_IS_CONSTANT_AST (last revision 2015-05-18 04:23 UTC by me at umakantpatil dot com)
Fix_type_cast_and_replace_IS_CONSTANT_INDEX_with_IS_CONSTANT_AST (last revision 2015-03-15 15:20 UTC by me at umakantpatil dot com)

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2015-03-15 04:12 UTC] gopalv@php.net 
I do not do any active development on pecl/hidef today.

Since this is a simple missing cast, if you have a patch or pull-request, I can merge it.
 [2015-03-15 14:59 UTC] me at umakantpatil dot com 
I fixed that cast. Now getting a different error.

/home/umakant/hidef/src/frozenarray.c:964:6: note: expected ‘const char **’ but argument is of type ‘char **’
/home/umakant/hidef/src/frozenarray.c: In function ‘frozen_array_free_zval_ptr’:
/home/umakant/hidef/src/frozenarray.c:1024:8: error: ‘IS_CONSTANT_ARRAY’ undeclared (first use in this function)
[frozenarray.lo]

Okay I'll try to get the fix and attach the patch.
 [2015-03-15 15:22 UTC] me at umakantpatil dot com 
I have attached the fix. Could you please get into the trunk and release the new version?
 [2015-04-06 20:54 UTC] cmb@php.net
-Assigned To: +Assigned To: gopalv
 [2015-05-16 13:25 UTC] cmb@php.net 
Related To: Bug #67511
 [2015-05-16 13:29 UTC] cmb@php.net 
The patch would break compilation with former PHP versions,
because IS_CONSTANT_AST is defined as of PHP 5.6.0 only.
 [2015-05-18 04:01 UTC] me at umakantpatil dot com 
Okay. I'll correct the patch. 
Thanks
 [2015-05-18 04:27 UTC] me at umakantpatil dot com 
Hi cmb,

According to you the previous patch would not work for versions below 5.6.0.

I have added a new patch which fixes the problem.

The new patch has been tested with versions 5.4.8 and 5.6.6 both.

Let me know if there are any issues. I don't what it would take to post this patch in the truck of hidef. It has been long time since I posted the patch.

Anyway thanks to hear from you on patch.
 [2015-05-20 18:40 UTC] cmb@php.net 
> I don't what it would take to post this patch in the truck of
> hidef.

Somebody with PECL karma would have to do this. If you're
interested in helping to maintain hidef, see
<https://pecl.php.net/account-request.php>.
 [2015-07-24 07:32 UTC] me at umakantpatil dot com 
I had applied long back for the account but didn't hear anything from the team. Is there a certain thing other than mentioned in the docs I have to consider while applying which I missed out ?
 [2015-09-15 11:51 UTC] me at umakantpatil dot com 
I have fixed this issue at a different repo:- https://github.com/umakantp/hidef

Just adding if anyone wants it. Since my account was not approved to do commits in the original repo.
 [2017-10-24 07:04 UTC] kalle@php.net
-Status: Assigned +Status: Open -Assigned To: gopalv +Assigned To:
 [2017-10-24 16:57 UTC] cmb@php.net
-Status: Open +Status: Suspended
 [2017-10-24 16:57 UTC] cmb@php.net 
Since Gopal is the sole maintainer of the extension, and
apparently hasn't time to fix the issue, I'm suspending this
ticket.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu Dec 26 20:01:29 2024 UTC