php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #66555 Always false condition in ext/gd/libgd/gdkanji.c
Submitted: 2014-01-22 20:08 UTC Modified: -
From: mathew1800 at gmail dot com Assigned:
Status: Closed Package: GD related
PHP Version: Irrelevant OS: Irrelevant
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: mathew1800 at gmail dot com
New email:
PHP Version: OS:

 

 [2014-01-22 20:08 UTC] mathew1800 at gmail dot com 
Description:
------------
See: https://github.com/php/php-src/blob/master/ext/gd/libgd/gdkanji.c#L333

You should see the lines:

  if (daku)
    {
      if ((*p2 >= 74 && *p2 <= 103) || (*p2 >= 110 && *p2 <= 122))
        (*p2)++;
      else if (*p2 == 131 && *p2 == 69)
        *p2 = 148;
    }

"else if (*p2 == 131 && *p2 == 69)" will always be false.

Test script:
---------------
Not necessary

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2016-07-23 15:11 UTC] cmb@php.net 
Automatic comment on behalf of cmb
Revision: http://git.php.net/?p=php-src.git;a=commit;h=2c16b9cf62072afefb9a318f4a503bb9335f8537
Log: Fix #66555: Always false condition in ext/gd/libgd/gdkanji.c
 [2016-07-23 15:11 UTC] cmb@php.net
-Status: Open +Status: Closed
 [2016-10-17 10:10 UTC] bwoebi@php.net 
Automatic comment on behalf of cmb
Revision: http://git.php.net/?p=php-src.git;a=commit;h=2c16b9cf62072afefb9a318f4a503bb9335f8537
Log: Fix #66555: Always false condition in ext/gd/libgd/gdkanji.c
 
PHP Copyright © 2001-2025 The PHP Group
All rights reserved. 		Last updated: Mon Mar 31 07:01:29 2025 UTC