|
php.net | support | documentation | report a bug | advanced search | search howto | statistics | random bug | login |
[2013-04-02 07:26 UTC] php-bugs-2013 at ryandesign dot com
Description:
------------
Building the rar pecl module with php 5.5.0beta1 and 5.5.0beta2 fails:
rarentry.c:183:17: error: too few arguments to function call, expected 4, have 3
NULL TSRMLS_CC);
^
1 error generated.
make: *** [rarentry.lo] Error 1
It built successfully using an earlier alpha version of php 5.5.0.
PatchesPull RequestsHistoryAllCommentsChangesGit/SVN commits
|
|||||||||||||||||||||||||||
Copyright © 2001-2025 The PHP GroupAll rights reserved. |
Last updated: Fri Oct 24 11:00:02 2025 UTC |
Thanks, that works. But the patch did not apply cleanly. This chunk did not apply: *************** *** 754,760 **** if ((*archive = expand_filepath(tmp_archive, NULL TSRMLS_CC)) == NULL) { php_stream_wrapper_log_error(wrapper, options TSRMLS_CC, - "Could not expand the path %s", archive); goto cleanup; } } --- 754,760 ---- if ((*archive = expand_filepath(tmp_archive, NULL TSRMLS_CC)) == NULL) { php_stream_wrapper_log_error(wrapper, options TSRMLS_CC, + "Could not expand the path %s", *archive); goto cleanup; } } In the 3.0.1 code, the error message does not use "archive" but "tmp_archive". Yet another difference between the code in the repository (whose php_rar.h says it's version 3.0.0) and the code that was released on pecl as 3.0.1 last year. You should get all the changes that were made for 3.0.1 into the repository so that 3.0.2 or whatever you release next does not reintroduce all the problems you fixed for 3.0.1: http://pecl.php.net/package-changelog.php?package=rar&release=3.0.1