php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Request #53457 number_format must support more than one character for thousands separator
Submitted: 2010-12-02 23:16 UTC Modified: 2010-12-03 11:10 UTC
From: mbabuskov at yahoo dot com Assigned: aharvey (profile)
Status: Closed Package: Strings related
PHP Version: Irrelevant OS: Any
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: mbabuskov at yahoo dot com
New email:
PHP Version: OS:

 

 [2010-12-02 23:16 UTC] mbabuskov at yahoo dot com 
Description:
------------
From the documentation for number_format function:

thousands_sep
    Sets the thousands separator.
    Only the first byte of thousands_sep is used. 

This makes it useless for any real world usage. The recommended HTML character for thousands separator is half-space, or   which is 8 characters. Function is only usable for obsolete or archaic systems

http://en.wikipedia.org/wiki/Thin_space
http://en.wikipedia.org/wiki/Thousands_separator#Digit_grouping

Test script:
---------------
echo number_format(123456, 2, '.', ' ');

Expected result:
----------------
123 456.00

Actual result:
--------------
123&456.00

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2010-12-03 10:37 UTC] aharvey@php.net
-Status: Open +Status: Assigned -Assigned To: +Assigned To: aharvey
 [2010-12-03 11:10 UTC] aharvey@php.net 
Automatic comment from SVN on behalf of aharvey
Revision: http://svn.php.net/viewvc/?view=revision&revision=305937
Log: Implement FR #53457 (number_format must support more than one character for
thousands separator).
 [2010-12-03 11:10 UTC] aharvey@php.net
-Status: Assigned +Status: Closed
 [2010-12-03 11:10 UTC] aharvey@php.net 
This bug has been fixed in SVN.

Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
 
Thank you for the report, and for helping us make PHP better.

Implemented on trunk.
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Thu Nov 21 13:01:29 2024 UTC