php.net |  support |  documentation |  report a bug |  advanced search |  search howto |  statistics |  random bug |  login

go to bug id or search bugs for

Bug #50537 llabs() not defined but is defined..
Submitted: 2009-12-20 15:23 UTC Modified: 2009-12-29 01:00 UTC
From: dax at enst dot fr Assigned: jani (profile)
Status: No Feedback Package: Compile Failure
PHP Version: 5.3.1 OS: Solaris9
Private report: No CVE-ID: None
View Developer Edit
Welcome back! If you're the original bug submitter, here's where you can edit the bug or add additional notes.
If you forgot your password, you can retrieve your password here.
Password:
Status:
Package:
Bug Type:
Summary:
From: dax at enst dot fr
New email:
PHP Version: OS:

 

 [2009-12-20 15:23 UTC] dax at enst dot fr 
Description:
------------
IMHO, it seems to me that the fix of the Bug-id 50226 by Jani in php_date.c is wrong.
Really, are you sure at line 38 it is #ifndef HAVE_LLABS
and not #ifdef HAVE_LLABS ? 
With #ifdef the compilation runs finely until the end.
Please can you check ?

Philippe

Reproduce code:
---------------
#ifdef PHP_WIN32
# include "win32/php_stdint.h"
#endif

#ifdef HAVE_LLABS
# if defined(__GNUC__) && __GNUC__ < 3
static __inline __int64_t llabs( __int64_t i ) { return i >= 0 ? i : -i; }
# elif defined(NETWARE) && defined(__MWERKS__)
static __inline long long llabs( long long i ) { return i >= 0 ? i : -i; }
# endif
#endif

Patches

Pull Requests

History

AllCommentsChangesGit/SVN commitsRelated reports
 [2009-12-21 02:46 UTC] aharvey@php.net 
FTR, I believe the OP is actually referring to the fix for bug #50266, which was revision 291371.
 [2009-12-21 10:14 UTC] jani@php.net 
1. Fix the summary. No idea what your problem really is.
2. Yes, I'm quite sure we should not define llabs() if it's already defined. WHAT exactly is the error you get?
 [2009-12-29 01:00 UTC] php-bugs at lists dot php dot net 
No feedback was provided for this bug for over a week, so it is
being suspended automatically. If you are able to provide the
information that was originally requested, please do so and change
the status of the bug back to "Open".
 
PHP Copyright © 2001-2024 The PHP Group
All rights reserved. 		Last updated: Sun Dec 22 11:01:30 2024 UTC